autocomplete: Exclude muted users from user-mention autocomplete

Co-authored-by: Sayed Mahmood Sayedi <[email protected]>

Author: 2 people

lib/model/autocomplete.dart

@@ -12,6 +12,7 @@ import 'compose.dart';
 import 'emoji.dart';
 import 'narrow.dart';
 import 'store.dart';
+import 'user.dart';
 
 extension ComposeContentAutocomplete on ComposeContentController {
   AutocompleteIntent<ComposeAutocompleteQuery>? autocompleteIntent() {
@@ -648,7 +649,7 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
   }
 
   MentionAutocompleteResult? _testUser(MentionAutocompleteQuery query, User user) {
-    if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
+    if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache, store)) {
       return UserMentionAutocompleteResult(userId: user.userId);
     }
     return null;
@@ -753,9 +754,10 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
       || wildcardOption.localizedCanonicalString(localizations).contains(_lowercase);
   }
 
-  bool testUser(User user, AutocompleteDataCache cache) {
+  bool testUser(User user, AutocompleteDataCache cache, UserStore store) {
     // TODO(#236) test email too, not just name
     if (!user.isActive) return false;
+    if (store.isUserMuted(user.userId)) return false;
 
     return _testName(user, cache);
   }

test/model/autocomplete_test.dart

@@ -404,19 +404,33 @@ void main() {
   });
 
   group('MentionAutocompleteQuery.testUser', () {
+    late PerAccountStore store;
+
     void doCheck(String rawQuery, User user, bool expected) {
       final result = MentionAutocompleteQuery(rawQuery)
-        .testUser(user, AutocompleteDataCache());
+        .testUser(user, AutocompleteDataCache(), store);
       expected ? check(result).isTrue() : check(result).isFalse();
     }
 
     test('user is always excluded when not active regardless of other criteria', () {
+      store = eg.store();
+
       doCheck('Full Name', eg.user(fullName: 'Full Name', isActive: false), false);
       // When active then other criteria will be checked
       doCheck('Full Name', eg.user(fullName: 'Full Name', isActive: true), true);
     });
 
+    test('user is always excluded when muted, regardless of other criteria', () async {
+      store = eg.store();
+      await store.setMutedUsers([1]);
+      doCheck('Full Name', eg.user(userId: 1, fullName: 'Full Name'), false);
+      // When not muted, then other criteria will be checked
+      doCheck('Full Name', eg.user(userId: 2, fullName: 'Full Name'), true);
+    });
+
     test('user is included if fullname words match the query', () {
+      store = eg.store();
+
       doCheck('', eg.user(fullName: 'Full Name'), true);
       doCheck('', eg.user(fullName: ''), true); // Unlikely case, but should not crash
       doCheck('Full Name', eg.user(fullName: 'Full Name'), true);