deps: Update video_player 2.10.0, from 2.9.5

Changelog:
  https://pub.dev/packages/video_player/changelog#2100

One notable change is, support for opt-in use of
Flutter platform view:
  flutter/packages#8810

This commit also reverts the commit that pinned `video_player`
package:
  commit 2036178

    deps: Pin video_player to 2.9.5

    The latest version (2.10.0) makes significant changes internally
    and to the test API, which would require us to investigate and
    update our FakeVideoPlayerPlatform mock for tests.

    So, pin to the currently used version for now.

Upon investigating, the changes to the public API seem mostly
small, namely some deprecations in the platform interface class.
Which is only used in our tests, specifically by
FakeVideoPlayerPlatform. Otherwise, no behaviour change observed
while testing, as we are using the default options, i.e not using
Flutter platform view.

Author: rajveermalviya

pubspec.lock

@@ -847,7 +847,7 @@ packages:
     source: hosted
     version: "3.1.6"
   plugin_platform_interface:
-    dependency: "direct dev"
+    dependency: transitive
     description:
       name: plugin_platform_interface
       sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02"
@@ -1199,10 +1199,10 @@ packages:
     dependency: "direct main"
     description:
       name: video_player
-      sha256: "7d78f0cfaddc8c19d4cb2d3bebe1bfef11f2103b0a03e5398b303a1bf65eeb14"
+      sha256: "0d55b1f1a31e5ad4c4967bfaa8ade0240b07d20ee4af1dfef5f531056512961a"
       url: "https://pub.dev"
     source: hosted
-    version: "2.9.5"
+    version: "2.10.0"
   video_player_android:
     dependency: transitive
     description:
@@ -1223,10 +1223,10 @@ packages:
     dependency: "direct dev"
     description:
       name: video_player_platform_interface
-      sha256: df534476c341ab2c6a835078066fc681b8265048addd853a1e3c78740316a844
+      sha256: cf2a1d29a284db648fd66cbd18aacc157f9862d77d2cc790f6f9678a46c1db5a
       url: "https://pub.dev"
     source: hosted
-    version: "6.3.0"
+    version: "6.4.0"
   video_player_web:
     dependency: transitive
     description:

pubspec.yaml

@@ -61,7 +61,7 @@ dependencies:
   sqlite3_flutter_libs: ^0.5.13
   url_launcher: ^6.1.11
   url_launcher_android: ">=6.1.0"
-  video_player: 2.9.5 # TODO unpin and upgrade to latest version
+  video_player: ^2.10.0
   wakelock_plus: ^1.2.8
   zulip_plugin:
     path: ./packages/zulip_plugin
@@ -103,7 +103,6 @@ dev_dependencies:
   json_serializable: ^6.5.4
   legacy_checks: ^0.1.0
   pigeon: ^25.3.1
-  plugin_platform_interface: ^2.1.8
   stack_trace: ^1.11.1
   test: ^1.23.1
   test_api: ^0.7.3

test/widgets/lightbox_test.dart

@@ -6,9 +6,8 @@ import 'package:clock/clock.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter/material.dart';
-import 'package:plugin_platform_interface/plugin_platform_interface.dart';
-import 'package:video_player_platform_interface/video_player_platform_interface.dart';
 import 'package:video_player/video_player.dart';
+import 'package:video_player_platform_interface/video_player_platform_interface.dart';
 import 'package:zulip/api/model/events.dart';
 import 'package:zulip/api/model/model.dart';
 import 'package:zulip/model/localizations.dart';
@@ -32,16 +31,14 @@ const kTestVideoUrl = "https://a/video.mp4";
 const kTestUnsupportedVideoUrl = "https://a/unsupported.mp4";
 const kTestVideoDuration = Duration(seconds: 10);
 
-class FakeVideoPlayerPlatform extends Fake
-    with MockPlatformInterfaceMixin
-    implements VideoPlayerPlatform {
+class FakeVideoPlayerPlatform extends VideoPlayerPlatform {
   static final FakeVideoPlayerPlatform instance = FakeVideoPlayerPlatform();
 
   static void registerWith() {
     VideoPlayerPlatform.instance = instance;
   }
 
-  static const int _kTextureId = 0xffffffff;
+  static const int _kPlayerId = 0xffffffff;
 
   StreamController<VideoEvent> _streamController = StreamController<VideoEvent>();
   bool _hasError = false;
@@ -104,21 +101,21 @@ class FakeVideoPlayerPlatform extends Fake
   Future<void> init() async {}
 
   @override
-  Future<void> dispose(int textureId) async {
+  Future<void> dispose(int playerId) async {
     if (_hasError) {
       assert(!initialized);
-      assert(textureId == VideoPlayerController.kUninitializedTextureId);
+      assert(playerId == VideoPlayerController.kUninitializedPlayerId);
       return;
     }
 
     assert(initialized);
-    assert(textureId == _kTextureId);
+    assert(playerId == _kPlayerId);
   }
 
   @override
-  Future<int?> create(DataSource dataSource) async  {
+  Future<int?> createWithOptions(VideoCreationOptions options) async  {
     assert(!initialized);
-    if (dataSource.uri == kTestUnsupportedVideoUrl) {
+    if (options.dataSource.uri == kTestUnsupportedVideoUrl) {
       _hasError = true;
       _streamController.addError(
         PlatformException(
@@ -135,24 +132,24 @@ class FakeVideoPlayerPlatform extends Fake
       size: const Size(100, 100),
       rotationCorrection: 0,
     ));
-    return _kTextureId;
+    return _kPlayerId;
   }
 
   @override
-  Stream<VideoEvent> videoEventsFor(int textureId) {
-    assert(textureId == _kTextureId);
+  Stream<VideoEvent> videoEventsFor(int playerId) {
+    assert(playerId == _kPlayerId);
     return _streamController.stream;
   }
 
   @override
-  Future<void> setLooping(int textureId, bool looping) async {
-    assert(textureId == _kTextureId);
+  Future<void> setLooping(int playerId, bool looping) async {
+    assert(playerId == _kPlayerId);
     assert(!looping);
   }
 
   @override
-  Future<void> play(int textureId) async {
-    assert(textureId == _kTextureId);
+  Future<void> play(int playerId) async {
+    assert(playerId == _kPlayerId);
     _stopwatch?.start();
     _streamController.add(VideoEvent(
       eventType: VideoEventType.isPlayingStateUpdate,
@@ -161,8 +158,8 @@ class FakeVideoPlayerPlatform extends Fake
   }
 
   @override
-  Future<void> pause(int textureId) async {
-    assert(textureId == _kTextureId);
+  Future<void> pause(int playerId) async {
+    assert(playerId == _kPlayerId);
     _stopwatch?.stop();
     _streamController.add(VideoEvent(
       eventType: VideoEventType.isPlayingStateUpdate,
@@ -171,33 +168,33 @@ class FakeVideoPlayerPlatform extends Fake
   }
 
   @override
-  Future<void> setVolume(int textureId, double volume) async {
-    assert(textureId == _kTextureId);
+  Future<void> setVolume(int playerId, double volume) async {
+    assert(playerId == _kPlayerId);
   }
 
   @override
-  Future<void> seekTo(int textureId, Duration pos) async {
+  Future<void> seekTo(int playerId, Duration pos) async {
     _callLog.add('seekTo');
-    assert(textureId == _kTextureId);
+    assert(playerId == _kPlayerId);
 
     _lastSetPosition = pos >= kTestVideoDuration ? kTestVideoDuration : pos;
     _stopwatch?.reset();
   }
 
   @override
-  Future<void> setPlaybackSpeed(int textureId, double speed) async {
-    assert(textureId == _kTextureId);
+  Future<void> setPlaybackSpeed(int playerId, double speed) async {
+    assert(playerId == _kPlayerId);
   }
 
   @override
-  Future<Duration> getPosition(int textureId) async {
-    assert(textureId == _kTextureId);
+  Future<Duration> getPosition(int playerId) async {
+    assert(playerId == _kPlayerId);
     return position;
   }
 
   @override
-  Widget buildView(int textureId) {
-    assert(textureId == _kTextureId);
+  Widget buildViewWithOptions(VideoViewOptions options) {
+    assert(options.playerId == _kPlayerId);
     return const SizedBox(width: 100, height: 100);
   }
 }