emoji [nfc]: Remove UnicodeEmojiWidget.notoColorEmojiTextSize

Instead of passing this property each time the widget is used, we now
calculate it internally.

See discussion:
  #1629 (comment)

Author: sm-sayedi

lib/widgets/action_sheet.dart

@@ -774,7 +774,6 @@ class ReactionButtons extends StatelessWidget {
           : null,
         child: UnicodeEmojiWidget(
           emojiDisplay: emoji.emojiDisplay as UnicodeEmojiDisplay,
-          notoColorEmojiTextSize: 20.1,
           size: 24))));
   }
 

lib/widgets/autocomplete.dart

@@ -327,7 +327,6 @@ class _EmojiAutocompleteItem extends StatelessWidget {
   final EmojiAutocompleteResult option;
 
   static const _size = 24.0;
-  static const _notoColorEmojiTextSize = 19.3;
 
   @override
   Widget build(BuildContext context) {
@@ -341,9 +340,7 @@ class _EmojiAutocompleteItem extends StatelessWidget {
       ImageEmojiDisplay() =>
         ImageEmojiWidget(size: _size, emojiDisplay: emojiDisplay),
       UnicodeEmojiDisplay() =>
-        UnicodeEmojiWidget(
-          size: _size, notoColorEmojiTextSize: _notoColorEmojiTextSize,
-          emojiDisplay: emojiDisplay),
+        UnicodeEmojiWidget(size: _size, emojiDisplay: emojiDisplay),
       TextEmojiDisplay() => null, // The text is already shown separately.
     };
 

lib/widgets/emoji.dart

@@ -9,7 +9,6 @@ class UnicodeEmojiWidget extends StatelessWidget {
     super.key,
     required this.emojiDisplay,
     required this.size,
-    required this.notoColorEmojiTextSize,
     this.textScaler = TextScaler.noScaling,
   });
 
@@ -20,12 +19,6 @@ class UnicodeEmojiWidget extends StatelessWidget {
   /// This will be scaled by [textScaler].
   final double size;
 
-  /// A font size that, with Noto Color Emoji and our line-height config,
-  /// causes a Unicode emoji to occupy a square of size [size] in the layout.
-  ///
-  /// This has to be determined experimentally, as far as we know.
-  final double notoColorEmojiTextSize;
-
   /// The text scaler to apply to [size].
   ///
   /// Defaults to [TextScaler.noScaling].
@@ -38,14 +31,26 @@ class UnicodeEmojiWidget extends StatelessWidget {
       case TargetPlatform.fuchsia:
       case TargetPlatform.linux:
       case TargetPlatform.windows:
+        // A font size that, with Noto Color Emoji and our line-height
+        // config (the use of `forceStrutHeight: true`), causes a Unicode emoji
+        // to occupy a square of size [size] in the layout.
+        //
+        // Determined experimentally:
+        //   <https://github.com/zulip/zulip-flutter/pull/410#discussion_r1402808701>
+        //   <https://github.com/zulip/zulip-flutter/pull/1629#discussion_r2188037245>
+        final double notoColorEmojiTextSize = size * (14.5 / 17);
+
         return Text(
           textScaler: textScaler,
           style: TextStyle(
             fontFamily: 'Noto Color Emoji',
             fontSize: notoColorEmojiTextSize,
           ),
           strutStyle: StrutStyle(
-            fontSize: notoColorEmojiTextSize, forceStrutHeight: true),
+            fontSize: notoColorEmojiTextSize,
+            // Responsible for keeping the line height constant, even
+            // with ambient DefaultTextStyle.
+            forceStrutHeight: true),
           emojiDisplay.emojiUnicode);
 
       case TargetPlatform.iOS:
@@ -74,7 +79,11 @@ class UnicodeEmojiWidget extends StatelessWidget {
             style: TextStyle(
               fontFamily: 'Apple Color Emoji',
               fontSize: size),
-            strutStyle: StrutStyle(fontSize: size, forceStrutHeight: true),
+            strutStyle: StrutStyle(
+              fontSize: size,
+              // Responsible for keeping the line height constant, even
+              // with ambient DefaultTextStyle.
+              forceStrutHeight: true),
             emojiDisplay.emojiUnicode)),
         ]);
     }

lib/widgets/emoji_reaction.dart

@@ -270,13 +270,6 @@ class ReactionChip extends StatelessWidget {
 /// Should be scaled by [_emojiTextScalerClamped].
 const _squareEmojiSize = 17.0;
 
-/// A font size that, with Noto Color Emoji and our line-height config,
-/// causes a Unicode emoji to occupy a [_squareEmojiSize] square in the layout.
-///
-/// Determined experimentally:
-///   <https://github.com/zulip/zulip-flutter/pull/410#discussion_r1402808701>
-const _notoColorEmojiTextSize = 14.5;
-
 /// A [TextScaler] that limits Unicode and image emojis' max scale factor,
 /// to leave space for the label.
 ///
@@ -306,7 +299,6 @@ class _UnicodeEmoji extends StatelessWidget {
   Widget build(BuildContext context) {
     return UnicodeEmojiWidget(
       size: _squareEmojiSize,
-      notoColorEmojiTextSize: _notoColorEmojiTextSize,
       textScaler: _squareEmojiScalerClamped(context),
       emojiDisplay: emojiDisplay);
   }
@@ -563,7 +555,6 @@ class EmojiPickerListEntry extends StatelessWidget {
   final Message message;
 
   static const _emojiSize = 24.0;
-  static const _notoColorEmojiTextSize = 20.1;
 
   void _onPressed() {
     // Dismiss the enclosing action sheet immediately,
@@ -590,9 +581,7 @@ class EmojiPickerListEntry extends StatelessWidget {
       ImageEmojiDisplay() =>
         ImageEmojiWidget(size: _emojiSize, emojiDisplay: emojiDisplay),
       UnicodeEmojiDisplay() =>
-        UnicodeEmojiWidget(
-          size: _emojiSize, notoColorEmojiTextSize: _notoColorEmojiTextSize,
-          emojiDisplay: emojiDisplay),
+        UnicodeEmojiWidget(size: _emojiSize, emojiDisplay: emojiDisplay),
       TextEmojiDisplay() => null, // The text is already shown separately.
     };