model [nfc]: Pass TwentyFourHourTimeMode to MessageTimestampStyle.format

Author: chrisbobbe

lib/widgets/lightbox.dart

@@ -177,8 +177,11 @@ class _LightboxPageLayoutState extends State<_LightboxPageLayout> {
 
     PreferredSizeWidget? appBar;
     if (_headerFooterVisible) {
-      final timestampText = MessageTimestampStyle.lightbox.format(
-        widget.message.timestamp, now: DateTime.now(), zulipLocalizations: zulipLocalizations);
+      final timestampText = MessageTimestampStyle.lightbox
+        .format(widget.message.timestamp,
+          now: DateTime.now(),
+          twentyFourHourTimeMode: store.userSettings.twentyFourHourTime,
+          zulipLocalizations: zulipLocalizations);
 
       // We use plain [AppBar] instead of [ZulipAppBar], even though this page
       // has a [PerAccountStore], because:

lib/widgets/message_list.dart

@@ -1841,11 +1841,13 @@ class DateText extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    final store = PerAccountStoreWidget.of(context);
     final messageListTheme = MessageListTheme.of(context);
     final zulipLocalizations = ZulipLocalizations.of(context);
     final formattedTimestamp = MessageTimestampStyle.dateOnlyRelative.format(
       timestamp,
       now: ZulipBinding.instance.utcNow().toLocal(),
+      twentyFourHourTimeMode: store.userSettings.twentyFourHourTime,
       zulipLocalizations: zulipLocalizations)!;
     return Text(
       style: TextStyle(
@@ -1887,8 +1889,11 @@ class SenderRow extends StatelessWidget {
     final designVariables = DesignVariables.of(context);
 
     final sender = store.getUser(message.senderId);
-    final timestamp = timestampStyle.format(
-      message.timestamp, now: DateTime.now(), zulipLocalizations: zulipLocalizations);
+    final timestamp = timestampStyle
+      .format(message.timestamp,
+        now: DateTime.now(),
+        twentyFourHourTimeMode: store.userSettings.twentyFourHourTime,
+        zulipLocalizations: zulipLocalizations);
 
     final showAsMuted = _showAsMuted(context, store);
 
@@ -2016,6 +2021,7 @@ enum MessageTimestampStyle {
     int messageTimestamp, {
     required DateTime now,
     required ZulipLocalizations zulipLocalizations,
+    required TwentyFourHourTimeMode twentyFourHourTimeMode,
   }) {
     final asDateTime =
       DateTime.fromMillisecondsSinceEpoch(1000 * messageTimestamp);

test/widgets/message_list_test.dart

@@ -1656,6 +1656,7 @@ void main() {
             final result = style.format(
               timestamp,
               now: testBinding.utcNow().toLocal(),
+              twentyFourHourTimeMode: TwentyFourHourTimeMode.localeDefault,
               zulipLocalizations: zulipLocalizations);
             check(result).equals(expected);
           });