Skip to content

Commit e55cebd

Browse files
chrisbobbegnprice
authored andcommitted
emoji test [nfc]: Pull out prepare function for reuse
1 parent 39d57e2 commit e55cebd

File tree

1 file changed

+18
-36
lines changed

1 file changed

+18
-36
lines changed

test/model/emoji_test.dart

Lines changed: 18 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,24 @@ import 'package:zulip/model/store.dart';
1010
import '../example_data.dart' as eg;
1111

1212
void main() {
13+
PerAccountStore prepare({
14+
Map<String, RealmEmojiItem> realmEmoji = const {},
15+
bool addServerDataForPopular = true,
16+
Map<String, List<String>>? unicodeEmoji,
17+
}) {
18+
final store = eg.store(
19+
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
20+
21+
if (addServerDataForPopular || unicodeEmoji != null) {
22+
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
23+
final emojiData = addServerDataForPopular
24+
? eg.serverEmojiDataPopularPlus(extraEmojiData)
25+
: extraEmojiData;
26+
store.setServerEmojiData(emojiData);
27+
}
28+
return store;
29+
}
30+
1331
group('emojiDisplayFor', () {
1432
test('Unicode emoji', () {
1533
check(eg.store().emojiDisplayFor(emojiType: ReactionType.unicodeEmoji,
@@ -119,24 +137,6 @@ void main() {
119137
group('allEmojiCandidates', () {
120138
// TODO test emojiDisplay of candidates matches emojiDisplayFor
121139

122-
PerAccountStore prepare({
123-
Map<String, RealmEmojiItem> realmEmoji = const {},
124-
bool addServerDataForPopular = true,
125-
Map<String, List<String>>? unicodeEmoji,
126-
}) {
127-
final store = eg.store(
128-
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
129-
130-
if (addServerDataForPopular || unicodeEmoji != null) {
131-
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
132-
final emojiData = addServerDataForPopular
133-
? eg.serverEmojiDataPopularPlus(extraEmojiData)
134-
: extraEmojiData;
135-
store.setServerEmojiData(emojiData);
136-
}
137-
return store;
138-
}
139-
140140
test('popular emoji appear even when no server emoji data', () {
141141
final store = prepare(unicodeEmoji: null, addServerDataForPopular: false);
142142
check(store.debugServerEmojiData).isNull();
@@ -322,24 +322,6 @@ void main() {
322322
List<Condition<Object?>> arePopularResults = popularCandidates.map(
323323
(c) => isUnicodeResult(emojiCode: c.emojiCode)).toList();
324324

325-
PerAccountStore prepare({
326-
Map<String, RealmEmojiItem> realmEmoji = const {},
327-
bool addServerDataForPopular = true,
328-
Map<String, List<String>>? unicodeEmoji,
329-
}) {
330-
final store = eg.store(
331-
initialSnapshot: eg.initialSnapshot(realmEmoji: realmEmoji));
332-
333-
if (addServerDataForPopular || unicodeEmoji != null) {
334-
final extraEmojiData = ServerEmojiData(codeToNames: unicodeEmoji ?? {});
335-
final emojiData = addServerDataForPopular
336-
? eg.serverEmojiDataPopularPlus(extraEmojiData)
337-
: extraEmojiData;
338-
store.setServerEmojiData(emojiData);
339-
}
340-
return store;
341-
}
342-
343325
test('results can include all three emoji types', () async {
344326
final store = prepare(
345327
realmEmoji: {'1': eg.realmEmojiItem(emojiCode: '1', emojiName: 'happy')},

0 commit comments

Comments
 (0)