chore: removing unnecessary checks in gestures and tidy format

Author: chungwwei

lib/widgets/all_channels.dart

@@ -102,17 +102,11 @@ class AllChannelsListEntry extends StatelessWidget {
       padding: EdgeInsetsDirectional.only(start: 8, end: 4),
       child: GestureDetector(
         onTap: () {
-          if (!hasContentAccess) {
-            return;
-          }
           Navigator.push(context, MessageListPage.buildRoute(
             context: context,
             narrow: ChannelNarrow(channel.streamId)));
         },
         onLongPress: () {
-          if (!hasContentAccess) {
-            return;
-          }
           showChannelActionSheet(context, channelId: channel.streamId);
         },
         child: Row(spacing: 6, children: [

test/widgets/all_channels_test.dart

@@ -210,7 +210,7 @@ void main() {
     await setupAllChannelsPage(tester, channels: [eg.stream()]);
 
     await tester.longPress(find.byType(AllChannelsListEntry));
-    await tester.pumpAndSettle();
+    await tester.pump();
     await transitionDurationObserver.pumpPastTransition(tester);
 
     check(find.byType(BottomSheet)).findsOne();
@@ -219,15 +219,17 @@ void main() {
   testWidgets('navigate to channel feed on tap', (tester) async {
     final channel = eg.stream(name: 'some-channel');
     await setupAllChannelsPage(tester, channels: [channel]);
+
     connection.prepare(json: eg.newestGetMessagesResult(
       foundOldest: true, messages: [eg.streamMessage(stream: channel)]).toJson());
+    await tester.tap(find.byType(AllChannelsListEntry));
+    await tester.pump();
+    await transitionDurationObserver.pumpPastTransition(tester);
 
-    await tester.tap(find.byType(AllChannelsListEntry).at(0));
-    await tester.pumpAndSettle();
     check(find.descendant(
-        of: find.byType(MessageListPage),
-        matching: find.text('some-channel')),
-      ).findsOne();
+      of: find.byType(MessageListPage),
+      matching: find.text('some-channel')),
+    ).findsOne();
   });
 
   testWidgets('use toggle switch to subscribe/unsubscribe', (tester) async {