Skip to content

Commit ec8203b

Browse files
home: Add label as a required String to _NavigationBarButton
1 parent abc6351 commit ec8203b

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

lib/widgets/home.dart

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,35 +86,43 @@ class _HomePageState extends State<HomePage> {
8686

8787
@override
8888
Widget build(BuildContext context) {
89+
final zulipLocalizations = ZulipLocalizations.of(context);
90+
8991
const pageBodies = [
9092
(_HomePageTab.inbox, InboxPageBody()),
9193
(_HomePageTab.channels, SubscriptionListPageBody()),
9294
// TODO(#1094): Users
9395
(_HomePageTab.directMessages, RecentDmConversationsPageBody()),
9496
];
9597

96-
_NavigationBarButton button(_HomePageTab tab, IconData icon) {
98+
_NavigationBarButton button(_HomePageTab tab, IconData icon, String label) {
9799
return _NavigationBarButton(icon: icon,
98100
selected: _tab.value == tab,
99101
onPressed: () {
100102
_tab.value = tab;
101-
});
103+
},
104+
label: label);
102105
}
103106

104107
// TODO(a11y): add tooltips for these buttons
105108
final navigationBarButtons = [
106-
button(_HomePageTab.inbox, ZulipIcons.inbox),
109+
button(_HomePageTab.inbox, ZulipIcons.inbox,
110+
zulipLocalizations.inboxPageTitle),
107111
_NavigationBarButton( icon: ZulipIcons.message_feed,
108112
selected: false,
109113
onPressed: () => Navigator.push(context,
110114
MessageListPage.buildRoute(context: context,
111-
narrow: const CombinedFeedNarrow()))),
112-
button(_HomePageTab.channels, ZulipIcons.hash_italic),
115+
narrow: const CombinedFeedNarrow())),
116+
label: zulipLocalizations.navBarFeedLabel),
117+
button(_HomePageTab.channels, ZulipIcons.hash_italic,
118+
zulipLocalizations.channelsPageTitle),
113119
// TODO(#1094): Users
114-
button(_HomePageTab.directMessages, ZulipIcons.two_person),
120+
button(_HomePageTab.directMessages, ZulipIcons.two_person,
121+
zulipLocalizations.navBarDmLabel),
115122
_NavigationBarButton( icon: ZulipIcons.menu,
116123
selected: false,
117-
onPressed: () => _showMainMenu(context, tabNotifier: _tab)),
124+
onPressed: () => _showMainMenu(context, tabNotifier: _tab),
125+
label: zulipLocalizations.navBarMenuLabel),
118126
];
119127

120128
final designVariables = DesignVariables.of(context);
@@ -231,11 +239,13 @@ class _NavigationBarButton extends StatelessWidget {
231239
required this.icon,
232240
required this.selected,
233241
required this.onPressed,
242+
required this.label,
234243
});
235244

236245
final IconData icon;
237246
final bool selected;
238247
final void Function() onPressed;
248+
final String label;
239249

240250
@override
241251
Widget build(BuildContext context) {

0 commit comments

Comments
 (0)