fix 1429: avoid muting self-1:1 DM thread

gnprice · gnprice · commit f35625eafc2f · 2025-05-28T11:08:04.000-07:00
diff --git a/lib/model/user.dart b/lib/model/user.dart
@@ -84,7 +84,8 @@ mixin UserStore on PerAccountStoreBase {
   /// By default, looks for the recipients in [UserStore.mutedUsers] unless
   /// [mutedUsers] is non-null, in which case looks in the latter.
   bool allRecipientsMuted(DmNarrow narrow, {List<MutedUserItem>? mutedUsers}) {
-    return !narrow.otherRecipientIds.any((id) => !isUserMuted(id, mutedUsers: mutedUsers));
+    return narrow.otherRecipientIds.isNotEmpty // TODO fix this method's doc
+      && !narrow.otherRecipientIds.any((id) => !isUserMuted(id, mutedUsers: mutedUsers));
   }
 
   /// Whether the given event will change the result of [allRecipientsMuted]

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,8 @@ mixin UserStore on PerAccountStoreBase {`
`84`	`84`	`/// By default, looks for the recipients in [UserStore.mutedUsers] unless`
`85`	`85`	`/// [mutedUsers] is non-null, in which case looks in the latter.`
`86`	`86`	`bool allRecipientsMuted(DmNarrow narrow, {List<MutedUserItem>? mutedUsers}) {`
`87`		`- return !narrow.otherRecipientIds.any((id) => !isUserMuted(id, mutedUsers: mutedUsers));`
	`87`	`+ return narrow.otherRecipientIds.isNotEmpty // TODO fix this method's doc`
	`88`	`+ && !narrow.otherRecipientIds.any((id) => !isUserMuted(id, mutedUsers: mutedUsers));`
`88`	`89`	`}`
`89`	`90`
`90`	`91`	`/// Whether the given event will change the result of [allRecipientsMuted]`