Commit faa4707
committed
action_sheet [nfc]: Comment on user-topic button about client-side check
Zixuan points out that this could be helpful here:
#1301 (comment)
This probably makes sense to not do until #1078, when we'll have
separate buttons for each of the four possible user-topic states.
This same comment *could* be added on various other action-sheet
buttons. But realistically it wouldn't make a difference on any that
we've implemented so far: all the others (besides this and
ResolveUnresolveButton) are on the message action sheet, and they're
all about actions that would only be done by the self-user --
starring, marking as unread, etc. -- so they can't be done without
the user's awareness, and will rarely be done anyway because you'd
need to do it on a different client.1 parent e254bd1 commit faa4707
1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
364 | 368 | | |
365 | 369 | | |
366 | 370 | | |
| |||
0 commit comments