Commit ff6f142
inbox: Fix bug where VoiceOver focus lost on collapse/uncollapse
These DM, topic, and header rows shouldn't be leaking their
semantics data up the semantics tree -- all their data has been
propagating up to the SemanticsNode for each section, i.e., the
all-DMs section and the channel sections. (Those SemanticsNodes are
created for each section by the StickyHeaderListView, since that
view's "items"/"children" are the sections.)
Happily, somehow this fixes the following item in #537, in my
testing with VoiceOver on iPhone 26.2.1:
> When collapsing or uncollapsing a channel header, the focus
> sometimes gets moved elsewhere unexpectedly.
That description makes the symptom sound milder than what I've been
seeing: it seems like the focus was being moved up to the app bar
pretty much every time I collapsed a section, making the
collapse/uncollapse feature basically unusable with VoiceOver. Now,
the focus doesn't move at all; it just stays on the header that I
just collapsed.
Related: #5371 parent 9d24c7b commit ff6f142
1 file changed
+12
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
| 272 | + | |
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
318 | 321 | | |
319 | 322 | | |
320 | 323 | | |
| |||
408 | 411 | | |
409 | 412 | | |
410 | 413 | | |
411 | | - | |
| 414 | + | |
412 | 415 | | |
413 | 416 | | |
414 | 417 | | |
| |||
439 | 442 | | |
440 | 443 | | |
441 | 444 | | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
442 | 448 | | |
443 | 449 | | |
444 | 450 | | |
| |||
537 | 543 | | |
538 | 544 | | |
539 | 545 | | |
540 | | - | |
| 546 | + | |
541 | 547 | | |
542 | 548 | | |
543 | 549 | | |
| |||
576 | 582 | | |
577 | 583 | | |
578 | 584 | | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
579 | 588 | | |
580 | 589 | | |
581 | 590 | | |
| |||
0 commit comments