Skip to content

Commit 0034ae3

Browse files
chrisbobbegnprice
authored andcommitted
deps: Bump react-native-photo-view to (still) unreleased commit, for AGP 7
Before this change, we were pointing Yarn to a commit from 2018 on this repo's `master` branch, since a new release with the commit hadn't been made to NPM in a reasonable time. (It still hasn't.) Now, just bump to this project's current `master`, which is three commits ahead of that commit: https://github.com/alwx/react-native-photo-view/commits/master In particular, we want alwx/react-native-photo-view@ef532a348, which has the project's build.gradle stop using the `compile` dependency configuration in favor of `implementation`. The former has long been deprecated, and is an error with AGP 7, which we'd like to use soon: https://developer.android.com/studio/releases/gradle-plugin#dependency-configurations-removed We'd still like to stop using this library since it's almost totally unmaintained; that's #4217. Anyway, I tested on my iPhone 13 Pro running iOS 15.6, and on the office Android device (Samsung Galaxy S9 running Android 9), and I didn't notice any change in behavior of the lightbox. Regarding the `jcenter` exception for `photodraweeview` (see android/build.gradle in this commit), I tried removing the exception entirely, hoping that 1.1.3 might be available in the non-jcenter repos consulted by the build, even though 1.0.0 was not. But no, I again got an error that `photodraweeview` could not be found, so it looks like we still need to make an exception. See discussion of some further findings: #5507 (comment)
1 parent 40adbc1 commit 0034ae3

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ allprojects {
6565
// TODO: Get rid of this, when no deps use it.
6666
jcenter() {
6767
content {
68-
// Allow jcenter for only me.relex:photodraweeview:1.0.0:
68+
// Allow jcenter for only me.relex:photodraweeview:1.1.3:
6969
// https://docs.gradle.org/current/userguide/declaring_repositories.html#sec:declaring-repository-filter
7070
// Unfortunately, react-native-photo-view (which we want to
7171
// stop using: #4217) still depends on this, and it's only
7272
// available from jcenter.
7373
// TODO(#4217): Remove this and the whole `jcenter()` block.
74-
includeVersion("me.relex", "photodraweeview", "1.0.0")
74+
includeVersion("me.relex", "photodraweeview", "1.1.3")
7575
}
7676
}
7777
}

ios/Podfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,8 @@ PODS:
304304
- React-Core
305305
- react-native-netinfo (6.0.0):
306306
- React-Core
307-
- react-native-photo-view (1.5.2):
308-
- React
307+
- react-native-photo-view (1.5.3):
308+
- React-Core
309309
- react-native-safe-area-context (4.4.1):
310310
- RCT-Folly
311311
- RCTRequired
@@ -709,7 +709,7 @@ SPEC CHECKSUMS:
709709
react-native-cameraroll: 38b40d9033e4077b6c603f92f95c6d05fa7907df
710710
react-native-image-picker: cffb727cf2f59bd5c0408e30b3dbe0b935f88835
711711
react-native-netinfo: e849fc21ca2f4128a5726c801a82fc6f4a6db50d
712-
react-native-photo-view: 63e9e61da873531f931008b545d8d10c5373ddf8
712+
react-native-photo-view: ea0ec91bf5991a6843e740b1f47ab355171c996c
713713
react-native-safe-area-context: 99b24a0c5acd0d5dcac2b1a7f18c49ea317be99a
714714
react-native-simple-toast: 8ee5d23f0b92b935ab7434cdb65159ce12dfb4b7
715715
react-native-webview: d33e2db8925d090871ffeb232dfa50cb3a727581

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"react-native-document-picker": "^3.2.4",
6060
"react-native-gesture-handler": "^2.8.0",
6161
"react-native-image-picker": "4.8.4",
62-
"react-native-photo-view": "alwx/react-native-photo-view#c58fd6b30",
62+
"react-native-photo-view": "alwx/react-native-photo-view#91b873c85",
6363
"react-native-reanimated": "^2.2.0 <2.3.0",
6464
"react-native-safe-area-context": "^4.3.1",
6565
"react-native-screens": "^3.13.1",

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13445,9 +13445,9 @@ react-native-iphone-x-helper@^1.3.0:
1344513445
resolved "https://registry.yarnpkg.com/react-native-iphone-x-helper/-/react-native-iphone-x-helper-1.3.1.tgz#20c603e9a0e765fd6f97396638bdeb0e5a60b010"
1344613446
integrity sha512-HOf0jzRnq2/aFUcdCJ9w9JGzN3gdEg0zFE4FyYlp4jtidqU03D5X7ZegGKfT1EWteR0gPBGp9ye5T5FvSWi9Yg==
1344713447

13448-
react-native-photo-view@alwx/react-native-photo-view#c58fd6b30:
13449-
version "1.5.2"
13450-
resolved "https://codeload.github.com/alwx/react-native-photo-view/tar.gz/c58fd6b30d627fa23e39520d4fc3325ade8b0a51"
13448+
react-native-photo-view@alwx/react-native-photo-view#91b873c85:
13449+
version "1.5.3"
13450+
resolved "https://codeload.github.com/alwx/react-native-photo-view/tar.gz/91b873c85c5c48af41b93cf6bf34e0a40502f754"
1345113451
dependencies:
1345213452
prop-types "^15.5.10"
1345313453

0 commit comments

Comments
 (0)