fetching tests [nfc]: Avoid misleading initialState name

Author: chrisbobbe

src/chat/__tests__/fetchingReducer-test.js

@@ -25,7 +25,7 @@ describe('fetchingReducer', () => {
 
   describe('MESSAGE_FETCH_START', () => {
     test('if messages are fetched before or after the corresponding flag is set', () => {
-      const initialState = deepFreeze({
+      const prevState = deepFreeze({
         [HOME_NARROW_STR]: { older: false, newer: false },
       });
 
@@ -40,13 +40,13 @@ describe('fetchingReducer', () => {
         [HOME_NARROW_STR]: { older: true, newer: true },
       };
 
-      const newState = fetchingReducer(initialState, action);
+      const newState = fetchingReducer(prevState, action);
 
       expect(newState).toEqual(expectedState);
     });
 
     test('if key for narrow does not exist, it is created and corresponding flags are set', () => {
-      const initialState = deepFreeze({
+      const prevState = deepFreeze({
         [HOME_NARROW_STR]: { older: false, newer: false },
       });
 
@@ -63,13 +63,13 @@ describe('fetchingReducer', () => {
         [keyFromNarrow(narrow)]: { older: true, newer: false },
       };
 
-      const newState = fetchingReducer(initialState, action);
+      const newState = fetchingReducer(prevState, action);
 
       expect(newState).toEqual(expectedState);
     });
 
     test('if fetching for a search narrow, ignore', () => {
-      const initialState = deepFreeze({
+      const prevState = deepFreeze({
         [HOME_NARROW_STR]: {
           older: false,
           newer: false,
@@ -81,24 +81,24 @@ describe('fetchingReducer', () => {
         narrow: SEARCH_NARROW('some query'),
       });
 
-      const newState = fetchingReducer(initialState, action);
+      const newState = fetchingReducer(prevState, action);
 
-      expect(newState).toEqual(initialState);
+      expect(newState).toEqual(prevState);
     });
   });
 
   describe('MESSAGE_FETCH_ERROR', () => {
     test('reverses the effect of MESSAGE_FETCH_START as much as possible', () => {
       // As of the addition of this test, that means setting
       // DEFAULT_FETCHING as the key.
-      const initialState = deepFreeze({});
+      const state0 = deepFreeze({});
 
       const messageFetchStartAction = deepFreeze({
         ...eg.action.message_fetch_start,
         narrow: HOME_NARROW,
       });
 
-      const state1 = fetchingReducer(initialState, messageFetchStartAction);
+      const state1 = fetchingReducer(state0, messageFetchStartAction);
 
       const messageFetchErrorAction = deepFreeze({
         type: MESSAGE_FETCH_ERROR,
@@ -118,7 +118,7 @@ describe('fetchingReducer', () => {
 
   describe('MESSAGE_FETCH_COMPLETE', () => {
     test('sets corresponding fetching flags to false, if messages are received before or after', () => {
-      const initialState = deepFreeze({
+      const prevState = deepFreeze({
         [HOME_NARROW_STR]: { older: true, newer: true },
       });
 
@@ -133,14 +133,14 @@ describe('fetchingReducer', () => {
         [HOME_NARROW_STR]: { older: false, newer: true },
       };
 
-      const newState = fetchingReducer(initialState, action);
+      const newState = fetchingReducer(prevState, action);
 
       expect(newState).toEqual(expectedState);
     });
   });
 
   test('if fetched messages are from a search narrow, ignore them', () => {
-    const initialState = deepFreeze({
+    const prevState = deepFreeze({
       [HOME_NARROW_STR]: { older: true, newer: true },
     });
 
@@ -149,8 +149,8 @@ describe('fetchingReducer', () => {
       narrow: SEARCH_NARROW('some query'),
     });
 
-    const newState = fetchingReducer(initialState, action);
+    const newState = fetchingReducer(prevState, action);
 
-    expect(newState).toEqual(initialState);
+    expect(newState).toEqual(prevState);
   });
 });