Skip to content

Commit 07de661

Browse files
chrisbobbegnprice
authored andcommitted
ChatNavBar [nfc]: Let <LoadingBanner /> extend through right and left insets
This isn't actually a visible change, since LoadingBanner is given the same background color as the rest of ChatNavBar. But LoadingBanner didn't ask to be chopped off before it reaches the left or right edge of the screen. So let it extend.
1 parent 4356045 commit 07de661

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/nav/ChatNavBar.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export default function ChatNavBar(props: {|
154154
<ZulipStatusBar backgroundColor={streamColor} />
155155
<SafeAreaView
156156
mode="padding"
157-
edges={['top', 'right', 'left']}
157+
edges={['top']}
158158
style={{
159159
borderColor:
160160
streamColor === undefined
@@ -164,9 +164,11 @@ export default function ChatNavBar(props: {|
164164
backgroundColor: streamColor,
165165
}}
166166
>
167-
{/* This View is the app bar:
167+
{/* This SafeAreaView is the app bar:
168168
https://material.io/components/app-bars-top#specs */}
169-
<View
169+
<SafeAreaView
170+
mode="padding"
171+
edges={['right', 'left']}
170172
style={{
171173
// Ideally this would be `minHeight`, like in our other app bars,
172174
// to smoothly accommodate large font sizes. But we seem to have
@@ -184,7 +186,7 @@ export default function ChatNavBar(props: {|
184186
<View style={{ width: 20 }} />
185187
<Title color={textColor} narrow={narrow} editMessage={editMessage} />
186188
<ActionItems color={buttonColor} narrow={narrow} />
187-
</View>
189+
</SafeAreaView>
188190

189191
<LoadingBanner
190192
spinnerColor={spinnerColor}

0 commit comments

Comments
 (0)