android [nfc]: Move generic app-status code out of notifications/

Author: chrisbobbe

android/app/src/main/java/com/zulipmobile/ReactExtensions.kt

@@ -5,8 +5,56 @@ import com.facebook.react.ReactApplication
 import com.facebook.react.ReactInstanceManager
 import com.facebook.react.ReactNativeHost
 import com.facebook.react.bridge.ReactContext
+import com.facebook.react.common.LifecycleState
 import com.facebook.react.modules.core.DeviceEventManagerModule
 
+/**
+ * A distillation of ReactContext.getLifecycleState() and related information.
+ *
+ * See ReactContext.getAppStatus().
+ */
+enum class ReactAppStatus {
+    /**
+     * The main activity has either never yet been in the foreground,
+     * or never will again.  There might not be an active JS instance.
+     */
+    NOT_RUNNING,
+
+    /**
+     * The main activity has been in the foreground, is out of foreground
+     * now, but might come back.  There must be an active JS instance.
+     */
+    BACKGROUND,
+
+    /**
+     * The main activity is in the foreground.
+     * There must be an active JS instance.
+     */
+    FOREGROUND
+}
+
+val ReactContext.appStatus: ReactAppStatus
+    get() {
+        if (!hasActiveCatalystInstance())
+            return ReactAppStatus.NOT_RUNNING
+
+        // The RN lifecycleState:
+        //  * starts as BEFORE_CREATE
+        //  * responds to onResume, onPause, and onDestroy on the host Activity
+        //    * Android upstream docs on those:
+        //        https://developer.android.com/guide/components/activities/activity-lifecycle
+        //    * RN wires those through ReactActivity -> ReactActivityDelegate ->
+        //      ReactInstanceManager (as onHost{Resume,Pause,Destroy}) -> ReactContext
+        //  * notably goes straight BEFORE_CREATE -> RESUMED when first starting
+        //    (at least as of RN v0.59)
+        return when (lifecycleState!!) {
+            LifecycleState.BEFORE_CREATE -> ReactAppStatus.NOT_RUNNING
+            LifecycleState.BEFORE_RESUME -> ReactAppStatus.BACKGROUND
+            LifecycleState.RESUMED -> ReactAppStatus.FOREGROUND
+        }
+    }
+
+
 // A convenience shortcut.
 fun ReactContext.emitEvent(eventName: String, data: Any?) {
     getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter::class.java)

android/app/src/main/java/com/zulipmobile/notifications/NotifyReact.kt

@@ -6,7 +6,8 @@ import android.os.Bundle
 import android.util.Log
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.ReactContext
-import com.facebook.react.common.LifecycleState
+import com.zulipmobile.ReactAppStatus
+import com.zulipmobile.appStatus
 import com.zulipmobile.emitEvent
 
 /**
@@ -16,52 +17,6 @@ import com.zulipmobile.emitEvent
  * TODO: Replace this with a fresh implementation based on RN upstream docs.
  */
 
-/**
- * A distillation of ReactContext.getLifecycleState() and related information.
- *
- * See ReactContext.getAppStatus().
- */
-enum class ReactAppStatus {
-    /**
-     * The main activity has either never yet been in the foreground,
-     * or never will again.  There might not be an active JS instance.
-     */
-    NOT_RUNNING,
-
-    /**
-     * The main activity has been in the foreground, is out of foreground
-     * now, but might come back.  There must be an active JS instance.
-     */
-    BACKGROUND,
-
-    /**
-     * The main activity is in the foreground.
-     * There must be an active JS instance.
-     */
-    FOREGROUND
-}
-
-val ReactContext.appStatus: ReactAppStatus
-    get() {
-        if (!hasActiveCatalystInstance())
-            return ReactAppStatus.NOT_RUNNING
-
-        // The RN lifecycleState:
-        //  * starts as BEFORE_CREATE
-        //  * responds to onResume, onPause, and onDestroy on the host Activity
-        //    * Android upstream docs on those:
-        //        https://developer.android.com/guide/components/activities/activity-lifecycle
-        //    * RN wires those through ReactActivity -> ReactActivityDelegate ->
-        //      ReactInstanceManager (as onHost{Resume,Pause,Destroy}) -> ReactContext
-        //  * notably goes straight BEFORE_CREATE -> RESUMED when first starting
-        //    (at least as of RN v0.59)
-        return when (lifecycleState!!) {
-            LifecycleState.BEFORE_CREATE -> ReactAppStatus.NOT_RUNNING
-            LifecycleState.BEFORE_RESUME -> ReactAppStatus.BACKGROUND
-            LifecycleState.RESUMED -> ReactAppStatus.FOREGROUND
-        }
-    }
-
 internal fun notifyReact(reactContext: ReactContext?, data: Bundle) {
     // TODO deduplicate this with handleSend in SharingHelper.kt; see
     // https://github.com/zulip/zulip-mobile/pull/5146#discussion_r764437055

android/app/src/main/java/com/zulipmobile/sharing/SharingHelper.kt

@@ -10,9 +10,9 @@ import android.util.Log
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.ReactContext
 import com.facebook.react.bridge.WritableMap
+import com.zulipmobile.ReactAppStatus
 import com.zulipmobile.ZLog
-import com.zulipmobile.notifications.ReactAppStatus
-import com.zulipmobile.notifications.appStatus
+import com.zulipmobile.appStatus
 import com.zulipmobile.emitEvent
 
 @JvmField