tools: Add Gradle runner, to avoid cd android

And simplify various scripts and docs accordingly.

Author: gnprice

android/gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 # How to upgrade Gradle:
-#   $ ./gradlew wrapper --distribution-type=all --gradle-version=NEW_VERSION
-#   $ ./gradlew wrapper --distribution-type=all --gradle-version=NEW_VERSION
+#   $ tools/gradle wrapper --distribution-type=all --gradle-version=NEW_VERSION
+#   $ tools/gradle wrapper --distribution-type=all --gradle-version=NEW_VERSION
 # (Yep, run the same command twice.  The first updates this file so we use
 #  the new Gradle; the second updates the wrapper's jar and scripts, so that
 #  the wrapper is the one from the new Gradle too.)

docs/howto/build-run.md

@@ -280,8 +280,8 @@ java.nio.file.NoSuchFileException: /Users/chrisbobbe/dev/zulip-mobile/android/ap
   at sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:407)
 ```
 
-Try removing `android/.gradle`, running `./gradlew clean` from
-`android/`, and building again.
+Try removing `android/.gradle`, running `tools/gradle clean`,
+and building again.
 
 ### Build failure: No file known for: classes.dex
 
@@ -293,8 +293,8 @@ Execution failed for task ':app:packageDebug'.
    > No file known for: classes.dex
 ```
 
-Try removing `android/.gradle`, running `./gradlew clean` from
-`android/`, and building again.
+Try removing `android/.gradle`, running `tools/gradle clean`,
+and building again.
 
 ### Build failure: java.lang.UnsupportedClassVersionError, "Unsupported major.minor version 52.0"
 
@@ -343,7 +343,7 @@ Could not compile build file '/Users/chrisbobbe/dev/zulip-mobile/node_modules/@u
 This can sometimes happen if you're using JDK 13 to invoke the build
 command (e.g., when calling `tools/run-android`, or
 `tools/test native`, or
-`android/gradlew -p android :app:assembleDebug`). You can check the
+`tools/gradle :app:assembleDebug`). You can check the
 version by running `java -version`. It seems that upgrading to
 macOS 10.15 Catalina automatically upgrades Java to 13.
 
@@ -686,7 +686,7 @@ Sometimes, the build cache from previous builds can cause issues, and cleaning
 it can help:
 
 ```
-cd android && ./gradlew clean
+tools/gradle clean
 ```
 
 Optionally, reset iOS simulator:

package.json

@@ -9,7 +9,7 @@
     "android": "tools/run-android",
     "android-release": "react-native run-android --variant=release",
     "build:android": "tools/android apk",
-    "build:android-nokeys": "cd android && ./gradlew :app:assembleRelease",
+    "build:android-nokeys": "tools/gradle :app:assembleRelease",
     "build:ios": "cd ios && xcodebuild -scheme ZulipMobile archivexcodebuild -scheme ZulipMobile archive",
     "test": "tools/test",
     "prettier": "tools/fmt",

tools/android

@@ -64,14 +64,14 @@ do_apk() {
     check_yarn_link
     run_visibly yarn
 
-    run_visibly android/gradlew -p android :app:assembleRelease -Psigned -Psentry
+    run_visibly tools/gradle :app:assembleRelease -Psigned -Psentry
 }
 
 do_aab() {
     check_yarn_link
     run_visibly yarn
 
-    run_visibly android/gradlew -p android :app:bundleRelease -Psigned -Psentry
+    run_visibly tools/gradle :app:bundleRelease -Psigned -Psentry
 }
 
 case "${action}" in

tools/gradle

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+this_dir=${BASH_SOURCE[0]%/*}
+. "${this_dir}"/lib/ensure-coreutils.sh
+root_dir=$(readlink -f "${this_dir}"/..)
+
+exec "${root_dir}"/android/gradlew -p "${root_dir}"/android "$@"

tools/run-android

@@ -15,7 +15,7 @@ cd "${ROOT_DIR}"
 # These steps are based on observing `react-native run-android`
 # with a command `strace -eexecve -f react-native run-android`.
 
-run_visibly android/gradlew -p android -q :app:installDebug "$@"
+run_visibly tools/gradle -q :app:installDebug "$@"
 
 devices=(
     $(run_visibly adb devices | perl -0ne 'print "$_\n" for (/^(\S+) \s+ device$/gmx)')

tools/test

@@ -145,19 +145,15 @@ run_native_android() {
     files_check android/ \
         || return 0
 
-    (
-        cd android
-
-        ./gradlew -q :app:assembleDebug :app:assembleDebugUnitTest \
-            :app:bundleDebug || exit
-
-        # The `-q` suppresses noise from warnings about obsolete build config
-        # in our dependencies from the React Native ecosystem.
-        # But it also suppresses the names of tests that failed.
-        # So on failure, rerun without it.
-        ./gradlew -q :app:testDebugUnitTest \
-            || ./gradlew :app:testDebugUnitTest || exit
-    )
+    tools/gradle -q :app:assembleDebug :app:assembleDebugUnitTest \
+        :app:bundleDebug || return
+
+    # The `-q` suppresses noise from warnings about obsolete build config
+    # in our dependencies from the React Native ecosystem.
+    # But it also suppresses the names of tests that failed.
+    # So on failure, rerun without it.
+    tools/gradle -q :app:testDebugUnitTest \
+        || tools/gradle :app:testDebugUnitTest
 }
 
 run_native_ios() {