eslint: Enable react/no-unstable-nested-components

As planned; see discussion:
  #5393 (comment)

With allowAsProps: true, it turns out that none of our code is
actually flagged as problematic.

See doc:
  https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md

Author: chrisbobbe

.eslintrc.yaml

@@ -309,10 +309,15 @@ rules:
   react/prop-types: off  # We handle this better with types.
   react/require-default-props: off  # We handle this better with types.
 
+  react/no-unstable-nested-components:
+    - error
+    # Avoid some regressions in clarity:
+    #   https://github.com/zulip/zulip-mobile/pull/5393#discussion_r893924345
+    - allowAsProps: true
+
   # These could be good to fix.
   react/prefer-stateless-function: off
   react/sort-comp: off
-  react/no-unstable-nested-components: off
 
 
   #