topics tests: Start type-checking; use example data

Author: chrisbobbe

src/topics/__tests__/topicsReducer-test.js

@@ -1,17 +1,18 @@
+/* @flow strict-local */
+
 import deepFreeze from 'deep-freeze';
 
+import * as eg from '../../__tests__/lib/exampleData';
 import topicsReducer from '../topicsReducer';
-import { ACCOUNT_SWITCH, INIT_TOPICS, EVENT_NEW_MESSAGE } from '../../actionConstants';
+import { INIT_TOPICS } from '../../actionConstants';
 import { NULL_OBJECT } from '../../nullObjects';
 
-describe('streamsReducer', () => {
+describe('topicsReducer', () => {
   describe('ACCOUNT_SWITCH', () => {
     test('resets state to initial state', () => {
-      const prevState = deepFreeze([{ max_id: 1, name: 'some_topic' }]);
+      const prevState = deepFreeze({ [eg.stream.stream_id]: [{ max_id: 1, name: 'some topic' }] });
 
-      const action = deepFreeze({
-        type: ACCOUNT_SWITCH,
-      });
+      const action = eg.action.account_switch;
 
       const expectedState = NULL_OBJECT;
 
@@ -23,11 +24,11 @@ describe('streamsReducer', () => {
 
   describe('INIT_TOPICS', () => {
     test('adds new topics mapped to stream id', () => {
-      const prevState = NULL_OBJECT;
+      const prevState = eg.plusReduxState.topics;
 
       const action = deepFreeze({
         type: INIT_TOPICS,
-        streamId: 1,
+        streamId: eg.stream.stream_id,
         topics: [
           {
             max_id: 1,
@@ -41,7 +42,7 @@ describe('streamsReducer', () => {
       });
 
       const expectedState = {
-        '1': [
+        [eg.stream.stream_id]: [
           {
             max_id: 1,
             name: 'topic1',
@@ -60,7 +61,7 @@ describe('streamsReducer', () => {
 
     test('if topics for stream already exist, replace them', () => {
       const prevState = deepFreeze({
-        '1': [
+        [eg.stream.stream_id]: [
           {
             max_id: 1,
             name: 'some topic',
@@ -70,7 +71,7 @@ describe('streamsReducer', () => {
 
       const action = deepFreeze({
         type: INIT_TOPICS,
-        streamId: 1,
+        streamId: eg.stream.stream_id,
         topics: [
           {
             max_id: 2,
@@ -84,7 +85,7 @@ describe('streamsReducer', () => {
       });
 
       const expectedState = {
-        '1': [
+        [eg.stream.stream_id]: [
           {
             max_id: 2,
             name: 'topic1',
@@ -104,47 +105,37 @@ describe('streamsReducer', () => {
 
   describe('EVENT_NEW_MESSAGE', () => {
     test('if message is not in stream do not change state', () => {
-      const prevState = NULL_OBJECT;
-
-      const action = {
-        type: EVENT_NEW_MESSAGE,
-        message: {
-          id: 4,
-          type: 'private',
-          sender_id: 1,
-        },
-      };
+      const prevState = eg.plusReduxState.topics;
+
+      const action = eg.mkActionEventNewMessage(eg.pmMessage());
 
       const actualState = topicsReducer(prevState, action);
 
       expect(actualState).toBe(prevState);
     });
 
     test('if stream message and topic exists update with latest message id', () => {
+      const stream = eg.stream;
+      const topic = 'some topic';
+      const oldMessage = eg.streamMessage({ id: 1, stream, subject: topic });
+      const newMessage = eg.streamMessage({ id: 2, stream, subject: topic });
+
       const prevState = {
-        123: [
+        [stream.stream_id]: [
           {
-            max_id: 1,
-            name: 'some topic',
+            max_id: oldMessage.id,
+            name: topic,
           },
         ],
       };
 
-      const action = deepFreeze({
-        type: EVENT_NEW_MESSAGE,
-        message: {
-          id: 234,
-          type: 'stream',
-          stream_id: 123,
-          subject: 'some topic',
-        },
-      });
+      const action = eg.mkActionEventNewMessage(newMessage);
 
       const expectedState = {
-        123: [
+        [stream.stream_id]: [
           {
-            max_id: 234,
-            name: 'some topic',
+            max_id: newMessage.id,
+            name: topic,
           },
         ],
       };
@@ -155,23 +146,19 @@ describe('streamsReducer', () => {
     });
 
     test('if stream message and topic does not exist, add it', () => {
-      const prevState = NULL_OBJECT;
+      const stream = eg.stream;
+      const topic = 'some topic';
+      const message = eg.streamMessage({ stream, subject: topic });
 
-      const action = deepFreeze({
-        type: EVENT_NEW_MESSAGE,
-        message: {
-          id: 2,
-          type: 'stream',
-          stream_id: 123,
-          subject: 'some topic',
-        },
-      });
+      const prevState = eg.plusReduxState.topics;
+
+      const action = eg.mkActionEventNewMessage(message);
 
       const expectedState = {
-        123: [
+        [stream.stream_id]: [
           {
-            max_id: 2,
-            name: 'some topic',
+            max_id: message.id,
+            name: topic,
           },
         ],
       };