presence [nfc]: Clarify a name, userLastActiveAsRelativeTimeString

This is one of many, many "human" ways of describing a time.
And on its own it's really not a representation of "presence"
at all.

Author: gnprice

src/presence/__tests__/presenceModel-test.js

@@ -7,7 +7,7 @@ import { PRESENCE_RESPONSE, EVENT_PRESENCE } from '../../actionConstants';
 import {
   reducer as presenceReducer,
   getAggregatedPresence,
-  presenceToHumanTime,
+  userLastActiveAsRelativeTimeString,
   statusFromPresence,
   statusFromPresenceAndUserStatus,
 } from '../presenceModel';
@@ -85,10 +85,10 @@ describe('getAggregatedPresence', () => {
   });
 });
 
-describe('presenceToHumanTime', () => {
-  test('given a presence return human readable time', () => {
+describe('userLastActiveAsRelativeTimeString', () => {
+  test('given a presence return a relative time', () => {
     expect(
-      presenceToHumanTime(
+      userLastActiveAsRelativeTimeString(
         {
           aggregated: { client: 'website', status: 'active', timestamp: currentTimestamp - 240 },
         },
@@ -100,7 +100,7 @@ describe('presenceToHumanTime', () => {
 
   test('if less than a threshold, the user is currently active', () => {
     expect(
-      presenceToHumanTime(
+      userLastActiveAsRelativeTimeString(
         {
           aggregated: { client: 'website', status: 'active', timestamp: currentTimestamp - 100 },
         },
@@ -113,7 +113,7 @@ describe('presenceToHumanTime', () => {
   // TODO(server-6.0): Remove
   test('Pre-FL 148: if less than a day and user is "away", use imprecise "today"', () => {
     expect(
-      presenceToHumanTime(
+      userLastActiveAsRelativeTimeString(
         { aggregated: { client: 'website', status: 'active', timestamp: currentTimestamp - 100 } },
         { away: true, status_text: null, status_emoji: null },
         147,
@@ -125,7 +125,7 @@ describe('presenceToHumanTime', () => {
   //   above after the status parameter is gone.
   test('FL 148: if less than a day and user is "away", *don\'t* use imprecise "today"', () => {
     expect(
-      presenceToHumanTime(
+      userLastActiveAsRelativeTimeString(
         { aggregated: { client: 'website', status: 'active', timestamp: currentTimestamp - 100 } },
         { away: true, status_text: null, status_emoji: null },
         148,

src/presence/presenceModel.js

@@ -111,7 +111,7 @@ export const getAggregatedPresence = (presence: UserPresence): ClientPresence =>
   return { client, status, timestamp };
 };
 
-export const presenceToHumanTime = (
+export const userLastActiveAsRelativeTimeString = (
   presence: UserPresence,
   status: UserStatus,
   zulipFeatureLevel: number,

src/title/ActivityText.js

@@ -10,7 +10,7 @@ import { getZulipFeatureLevel } from '../selectors';
 import {
   getPresence,
   getUserPresenceByEmail,
-  presenceToHumanTime,
+  userLastActiveAsRelativeTimeString,
 } from '../presence/presenceModel';
 import { getUserStatus } from '../user-statuses/userStatusesModel';
 import ZulipText from '../common/ZulipText';
@@ -33,7 +33,7 @@ export default function ActivityText(props: Props): Node {
     return null;
   }
 
-  const activity = presenceToHumanTime(presence, userStatus, zulipFeatureLevel);
+  const activeTime = userLastActiveAsRelativeTimeString(presence, userStatus, zulipFeatureLevel);
 
-  return <ZulipText style={style} text={`Active ${activity}`} />;
+  return <ZulipText style={style} text={`Active ${activeTime}`} />;
 }