api: Add new custom profile field type, "Pronouns"

Fixes: #5517

Author: gnprice

src/api/modelTypes.js

@@ -28,7 +28,7 @@ export type * from './idTypes';
  */
 // This is an enum; see discussion on other enums.
 // eslint-disable-next-line ft-flow/type-id-match
-export type CustomProfileFieldTypeT = 1 | 2 | 3 | 4 | 5 | 6 | 7;
+export type CustomProfileFieldTypeT = 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8;
 
 /**
  * An enum of all valid values for CustomProfileFieldTypeT.
@@ -47,6 +47,7 @@ export const CustomProfileFieldType = {
   Link: (5: 5),
   User: (6: 6),
   ExternalAccount: (7: 7),
+  Pronouns: (8: 8),
 };
 
 // Check that the enum indeed has all and only the values of the type.

src/users/userSelectors.js

@@ -204,9 +204,10 @@ function interpretCustomProfileField(
     //   https://chat.zulip.org/#narrow/stream/378-api-design/topic/custom.20profile.20fields/near/1387379
 
     case 1: // CustomProfileFieldType.ShortText
+    case 8: // CustomProfileFieldType.Pronouns
     case 2: // CustomProfileFieldType.LongText
-      // The web client appears to treat these two cases identically.
-      // So we do the same.
+      // The web client appears to treat LongText identically to ShortText.
+      // Pronouns is explicitly meant to display the same as ShortText.
       return { displayType: 'text', text: value };
 
     case 3: {