api [nfc]: Use kFooBar naming instead of FOO_BAR, for constants

Author: chrisbobbe

src/api/constants.js

@@ -9,4 +9,4 @@
  */
 // This is hardcoded in the server, and therefore untranslated; that's
 // zulip/zulip#3639.
-export const NO_TOPIC_TOPIC: string = '(no topic)';
+export const kNoTopicTopic: string = '(no topic)';

src/compose/ComposeBox.js

@@ -362,7 +362,7 @@ export default function ComposeBox(props: Props): Node {
   const destinationNarrow = useMemo(() => {
     if (isStreamNarrow(narrow) || (isTopicNarrow(narrow) && isEditing)) {
       const streamId = streamIdOfNarrow(narrow);
-      const topic = topicInputState.value.trim() || apiConstants.NO_TOPIC_TOPIC;
+      const topic = topicInputState.value.trim() || apiConstants.kNoTopicTopic;
       return topicNarrow(streamId, topic);
     }
     invariant(isConversationNarrow(narrow), 'destination narrow must be conversation');
@@ -376,7 +376,7 @@ export default function ComposeBox(props: Props): Node {
 
     if (
       isTopicNarrow(destinationNarrow)
-      && topicOfNarrow(destinationNarrow) === apiConstants.NO_TOPIC_TOPIC
+      && topicOfNarrow(destinationNarrow) === apiConstants.kNoTopicTopic
       && mandatoryTopics
     ) {
       result.push('mandatory-topic-empty');

src/sharing/ShareWrapper.js

@@ -176,7 +176,7 @@ class ShareWrapperInner extends React.Component<Props, State> {
         : {
             content: messageToSend,
             type: 'stream',
-            subject: sendTo.topic || apiConstants.NO_TOPIC_TOPIC,
+            subject: sendTo.topic || apiConstants.kNoTopicTopic,
             // TODO(server-2.0): switch to numeric stream ID (#3918), not name;
             //   then drop streamName from SendTo
             to: sendTo.streamName,

src/utils/__tests__/narrow-test.js

@@ -267,7 +267,7 @@ describe('getNarrowsForMessage', () => {
       //
       // We don't store outbox messages with the empty string for
       // `subject`; if the topic input is left blank, we put down
-      // `apiConstants.NO_TOPIC_TOPIC` for `subject`.
+      // `apiConstants.kNoTopicTopic` for `subject`.
       label: 'Message in a stream with empty-string topic',
       message: {
         ...eg.streamMessage({ stream: eg.stream }),