account actions [nfc]: Make loginSuccess thunk action a GlobalThunkAction

Just as much as accountSwitch, this thunk action does touch the
global `state.accounts`, by either adding a new account at the front
of the array, or -- just like accountSwitch -- moving an existing
account to the front.

So, make it so callers treat it as a GlobalThunkAction, and have it
act like one in its implementation.

Author: chrisbobbe

src/account/accountActions.js

@@ -1,6 +1,6 @@
 /* @flow strict-local */
 import * as NavigationService from '../nav/NavigationService';
-import type { PerAccountAction, AllAccountsAction, ThunkAction, GlobalThunkAction } from '../types';
+import type { PerAccountAction, AllAccountsAction, GlobalThunkAction } from '../types';
 import {
   ACCOUNT_SWITCH,
   ACCOUNT_REMOVE,
@@ -57,15 +57,19 @@ const loginSuccessPlain = (realm: URL, email: string, apiKey: string): AllAccoun
 });
 
 export const loginSuccess =
-  (realm: URL, email: string, apiKey: string): ThunkAction<Promise<void>> =>
-  async (dispatch, getState) => {
+  (realm: URL, email: string, apiKey: string): GlobalThunkAction<Promise<void>> =>
+  async (dispatch, getState, { activeAccountDispatch }) => {
     NavigationService.dispatch(resetToMainTabs());
     dispatch(loginSuccessPlain(realm, email, apiKey));
 
-    await dispatch(registerAndStartPolling());
+    // Now dispatch some actions on the new, post-login active account.
+    // Because we just dispatched `loginSuccessPlain`, that new account is
+    // now the active account, so `activeAccountDispatch` will act on it.
+
+    await activeAccountDispatch(registerAndStartPolling());
 
     // TODO(#3881): Lots of issues with outbox sending
-    dispatch(sendOutbox());
+    activeAccountDispatch(sendOutbox());
 
-    dispatch(initNotifications());
+    activeAccountDispatch(initNotifications());
   };

src/start/AuthScreen.js

@@ -14,7 +14,7 @@ import type {
 import type { RouteProp } from '../react-navigation';
 import type { AppNavigationProp } from '../nav/AppNavigator';
 import isAppOwnDomain from '../isAppOwnDomain';
-import type { Dispatch } from '../types';
+import type { GlobalDispatch } from '../types';
 import {
   IconApple,
   IconPrivate,
@@ -24,7 +24,7 @@ import {
   IconTerminal,
 } from '../common/Icons';
 import type { SpecificIconType } from '../common/Icons';
-import { connect } from '../react-redux';
+import { connectGlobal } from '../react-redux';
 import styles from '../styles';
 import Centerer from '../common/Centerer';
 import Screen from '../common/Screen';
@@ -191,7 +191,7 @@ type SelectorProps = $ReadOnly<{||}>;
 type Props = $ReadOnly<{|
   ...OuterProps,
 
-  dispatch: Dispatch,
+  dispatch: GlobalDispatch,
   ...SelectorProps,
 |}>;
 
@@ -376,6 +376,6 @@ class AuthScreenInner extends PureComponent<Props> {
   }
 }
 
-const AuthScreen: ComponentType<OuterProps> = connect<{||}, _, _>()(AuthScreenInner);
+const AuthScreen: ComponentType<OuterProps> = connectGlobal<{||}, _, _>()(AuthScreenInner);
 
 export default AuthScreen;

src/start/DevAuthScreen.js

@@ -6,9 +6,9 @@ import { ActivityIndicator, View, FlatList } from 'react-native';
 
 import type { RouteProp } from '../react-navigation';
 import type { AppNavigationProp } from '../nav/AppNavigator';
-import type { DevUser, Dispatch } from '../types';
+import type { DevUser, GlobalDispatch } from '../types';
 import styles, { createStyleSheet } from '../styles';
-import { connect } from '../react-redux';
+import { connectGlobal } from '../react-redux';
 import ErrorMsg from '../common/ErrorMsg';
 import ZulipTextIntl from '../common/ZulipTextIntl';
 import Screen from '../common/Screen';
@@ -42,7 +42,7 @@ type SelectorProps = $ReadOnly<{||}>;
 type Props = $ReadOnly<{|
   ...OuterProps,
 
-  dispatch: Dispatch,
+  dispatch: GlobalDispatch,
   ...SelectorProps,
 |}>;
 
@@ -141,6 +141,6 @@ class DevAuthScreenInner extends PureComponent<Props, State> {
   }
 }
 
-const DevAuthScreen: ComponentType<OuterProps> = connect<{||}, _, _>()(DevAuthScreenInner);
+const DevAuthScreen: ComponentType<OuterProps> = connectGlobal<{||}, _, _>()(DevAuthScreenInner);
 
 export default DevAuthScreen;

src/start/PasswordAuthScreen.js

@@ -5,9 +5,9 @@ import { View } from 'react-native';
 
 import type { RouteProp } from '../react-navigation';
 import type { AppNavigationProp } from '../nav/AppNavigator';
-import type { Dispatch } from '../types';
+import type { GlobalDispatch } from '../types';
 import { createStyleSheet } from '../styles';
-import { connect } from '../react-redux';
+import { connectGlobal } from '../react-redux';
 import * as api from '../api';
 import ErrorMsg from '../common/ErrorMsg';
 import Input from '../common/Input';
@@ -42,7 +42,7 @@ type SelectorProps = $ReadOnly<{||}>;
 type Props = $ReadOnly<{|
   ...OuterProps,
 
-  dispatch: Dispatch,
+  dispatch: GlobalDispatch,
   ...SelectorProps,
 |}>;
 
@@ -153,7 +153,7 @@ class PasswordAuthScreenInner extends PureComponent<Props, State> {
   }
 }
 
-const PasswordAuthScreen: ComponentType<OuterProps> = connect<{||}, _, _>()(
+const PasswordAuthScreen: ComponentType<OuterProps> = connectGlobal<{||}, _, _>()(
   PasswordAuthScreenInner,
 );