Skip to content

Commit 505f78f

Browse files
committed
fetchActions tests [nfc]: Remove a TODO about jest.mocking a module
1 parent 880550e commit 505f78f

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

src/message/__tests__/fetchActions-test.js

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -355,19 +355,10 @@ describe('fetchActions', () => {
355355
test("rejects when validation-at-the-edge can't handle data, dispatches MESSAGE_FETCH_ERROR", async () => {
356356
// This validation is done in `migrateMessages`.
357357
//
358-
// TODO: See if we can mock `migrateMessages` to throw an
359-
// error unconditionally. We don't want to care specifically
360-
// how the data is malformed. Making this mock isn't
361-
// straightforward, in part because Jest wants you to mock
362-
// entire modules. `migrateMessages`'s caller is in the
363-
// same file as `migrateMessages`; it doesn't import it. So we
364-
// can't intercept such an import and have it give amock.
365-
//
366-
// For now, we simulate #4156, a real-life problem that a user
367-
// at server commit 0af2f9d838 ran into [1], by having
368-
// `user` be missing on reactions on a message.
369-
//
370-
// [1] https://github.com/zulip/zulip-mobile/issues/4156#issuecomment-655905093
358+
// Simulate #4156, a real-life problem that a user at server commit
359+
// 0af2f9d838 ran into [1], by having `user` be missing on reactions
360+
// on a message:
361+
// https://github.com/zulip/zulip-mobile/issues/4156#issuecomment-655905093
371362
const store = mockStore<GlobalState, Action>(baseState);
372363

373364
// Missing `user` (and `user_id`, for good measure), to

0 commit comments

Comments
 (0)