Skip to content

Commit 5100d57

Browse files
committed
UserStatusScreen: Rename "Update" button to "Save"; remove checkmark icon
I think this is much more common wording. And the checkmark icon is potentially confusing because it looks just like the checkmark on one of the status suggestions (SelectableOptionRow), if you've selected one. And it just doesn't feel normal to have an icon at all for a simple "OK" button like this.
1 parent 5b0e2f8 commit 5100d57

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/user-statuses/UserStatusScreen.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import ZulipButton from '../common/ZulipButton';
1818
import { getZulipFeatureLevel, getAuth, getOwnUserId } from '../selectors';
1919
import { getUserStatus } from './userStatusesModel';
2020
import type { UserStatus } from '../api/modelTypes';
21-
import { Icon, IconDone } from '../common/Icons';
21+
import { Icon } from '../common/Icons';
2222
import statusSuggestions from './userStatusTextSuggestions';
2323
import * as api from '../api';
2424

@@ -108,7 +108,7 @@ export default function UserStatusScreen(props: Props): Node {
108108
[serverSupportsEmojiStatus, navigation, auth],
109109
);
110110

111-
const handlePressUpdate = useCallback(() => {
111+
const handlePressSave = useCallback(() => {
112112
sendToServer({
113113
status_text: statusTextFromInputValue(textInputValue),
114114
status_emoji: statusEmojiFromInputValue(emojiInputValue),
@@ -165,12 +165,7 @@ export default function UserStatusScreen(props: Props): Node {
165165
);
166166
}}
167167
/>
168-
<ZulipButton
169-
style={styles.button}
170-
text="Update"
171-
onPress={handlePressUpdate}
172-
Icon={IconDone}
173-
/>
168+
<ZulipButton style={styles.button} text="Save" onPress={handlePressSave} />
174169
</Screen>
175170
);
176171
}

0 commit comments

Comments
 (0)