NestedNavRow [nfc]: Rename label to title

In preparation for adding a `subtitle` prop.

Author: chrisbobbe

src/common/NestedNavRow.js

@@ -16,11 +16,11 @@ type Props = $ReadOnly<{|
     +color?: string,
   |},
 
-  label: LocalizableReactText,
+  title: LocalizableReactText,
 
   // TODO: Should we make this unconfigurable? Should we have two reusable
   //   components, with and without this?
-  labelBoldUppercase?: true,
+  titleBoldUppercase?: true,
 
   /** Use this to navigate to a "nested" screen. */
   onPress: () => void,
@@ -33,7 +33,7 @@ type Props = $ReadOnly<{|
  * selectable option row instead, use `SelectableOptionRow`.
  */
 export default function NestedNavRow(props: Props): Node {
-  const { label, labelBoldUppercase, onPress, icon } = props;
+  const { title, titleBoldUppercase, onPress, icon } = props;
 
   const themeContext = useContext(ThemeContext);
 
@@ -55,23 +55,23 @@ export default function NestedNavRow(props: Props): Node {
           marginRight: 8,
           color: icon?.color ?? themeContext.color,
         },
-        label: {
-          ...(labelBoldUppercase ? { textTransform: 'uppercase', fontWeight: '500' } : undefined),
+        title: {
+          ...(titleBoldUppercase ? { textTransform: 'uppercase', fontWeight: '500' } : undefined),
         },
         iconRightFacingArrow: {
           textAlign: 'center',
           marginLeft: 8,
           color: themeContext.color,
         },
       }),
-    [themeContext, icon, labelBoldUppercase],
+    [themeContext, icon, titleBoldUppercase],
   );
 
   return (
     <Touchable onPress={onPress}>
       <View style={styles.container}>
         {!!icon && <icon.Component size={24} style={styles.iconFromProps} />}
-        <ZulipTextIntl style={styles.label} text={label} />
+        <ZulipTextIntl style={styles.title} text={title} />
         <View style={globalStyles.rightItem}>
           <IconRight size={24} style={styles.iconRightFacingArrow} />
         </View>

src/diagnostics/DiagnosticsScreen.js

@@ -31,25 +31,25 @@ export default function DiagnosticsScreen(props: Props): Node {
       <ZulipText style={styles.versionLabel} text={`v${nativeApplicationVersion ?? '?.?.?'}`} />
       <OptionDivider />
       <NestedNavRow
-        label="Variables"
+        title="Variables"
         onPress={() => {
           navigation.push('variables');
         }}
       />
       <NestedNavRow
-        label="Timing"
+        title="Timing"
         onPress={() => {
           navigation.push('timing');
         }}
       />
       <NestedNavRow
-        label="Storage"
+        title="Storage"
         onPress={() => {
           navigation.push('storage');
         }}
       />
       <NestedNavRow
-        label="Debug"
+        title="Debug"
         onPress={() => {
           navigation.push('debug');
         }}

src/settings/LegalScreen.js

@@ -34,7 +34,7 @@ export default function LegalScreen(props: Props): Node {
 
   return (
     <Screen title="Legal">
-      <NestedNavRow label="Zulip terms" onPress={openZulipPolicies} />
+      <NestedNavRow title="Zulip terms" onPress={openZulipPolicies} />
       <NestedNavRow
         // These are really terms set by the server admin responsible for
         // hosting the org, and that server admin may or may not represent
@@ -46,7 +46,7 @@ export default function LegalScreen(props: Props): Node {
         //   at the other link).
         // - These terms will apply to all users in the org, in all cases.
         //   We should link to them.
-        label={{
+        title={{
           text: 'Terms for {realmName}',
           values: { realmName: <ZulipText style={{ fontWeight: 'bold' }} text={realmName} /> },
         }}

src/settings/NotificationsScreen.js

@@ -87,7 +87,7 @@ export default function NotificationsScreen(props: Props): Node {
   return (
     <Screen title="Notifications">
       <ServerPushSetupBanner isDismissable={false} />
-      <NestedNavRow label="System settings for Zulip" onPress={handleSystemSettingsPress} />
+      <NestedNavRow title="System settings for Zulip" onPress={handleSystemSettingsPress} />
       <SwitchRow
         label="Notifications when offline"
         value={offlineNotification}

src/settings/SettingsScreen.js

@@ -69,28 +69,28 @@ export default function SettingsScreen(props: Props): Node {
       />
       <NestedNavRow
         icon={{ Component: IconNotifications }}
-        label="Notifications"
+        title="Notifications"
         onPress={() => {
           navigation.push('notifications');
         }}
       />
       <NestedNavRow
         icon={{ Component: IconLanguage }}
-        label="Language"
+        title="Language"
         onPress={() => {
           navigation.push('language');
         }}
       />
       <NestedNavRow
         icon={{ Component: IconDiagnostics }}
-        label="Diagnostics"
+        title="Diagnostics"
         onPress={() => {
           navigation.push('diagnostics');
         }}
       />
       <NestedNavRow
         icon={{ Component: IconMoreHorizontal }}
-        label="Legal"
+        title="Legal"
         onPress={() => {
           navigation.push('legal');
         }}

src/streams/SubscriptionsScreen.js

@@ -46,7 +46,7 @@ function AllStreamsButton(props: FooterProps): Node {
     navigation.push('all-streams');
   }, [navigation]);
 
-  return <NestedNavRow label="All streams" labelBoldUppercase onPress={handlePressAllScreens} />;
+  return <NestedNavRow title="All streams" titleBoldUppercase onPress={handlePressAllScreens} />;
 }
 
 export default function SubscriptionsScreen(props: Props): Node {