flow: Upgrade to v0.175.1

Changelog:
  https://github.com/facebook/flow/blob/main/Changelog.md#01751

The `signature-verification-failure` changed from a lint rule to a
normal error in v0.172.0, so we remove it from the `[lints]` section
in the config.

Author: chrisbobbe

.flowconfig

@@ -83,7 +83,6 @@ nonstrict-import=warn
 deprecated-type=warn
 unsafe-getters-setters=warn
 unnecessary-invariant=warn
-signature-verification-failure=warn
 
 ; ours
 sketchy-number=error
@@ -125,4 +124,4 @@ exact_by_default=true
 enums=true
 
 [version]
-^0.170.0
+^0.175.1

package.json

@@ -109,7 +109,7 @@
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-react": "^7.24.0",
     "eslint-plugin-react-hooks": "^4.5.0",
-    "flow-bin": "^0.170.0",
+    "flow-bin": "^0.175.1",
     "flow-coverage-report": "^0.8.0",
     "flow-parser": "<0.159.0",
     "flow-typed": "^3.3.1",

src/__tests__/lib/exampleData.js

@@ -680,7 +680,6 @@ export const plusReduxState: GlobalState & PerAccountState = reduxState({
  */
 export const reduxStatePlus = (
   extra?: $Rest<GlobalState, { ... }>,
-  // $FlowFixMe[not-an-object]
 ): GlobalState & PerAccountState =>
   dubJointState(deepFreeze({ ...(plusReduxState: GlobalState), ...extra }));
 

src/storage/__tests__/sqlite-test.js

@@ -243,6 +243,7 @@ describe('expo-sqlite', () => {
       expect(await select(db, 'SELECT x FROM foo')).toEqual([{ x: 1 }]);
 
       // $FlowFixMe[prop-missing]
+      // $FlowFixMe[incompatible-use]
       db._db.allowUnhandled();
 
       let _ops = undefined;

src/storage/migrations.js

@@ -134,7 +134,8 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
   '10': state => {
     const newLocaleNames = { zh: 'zh-Hans', id: 'id-ID' };
     // $FlowIgnore[prop-missing]: `locale` renamed to `language` in 31
-    const { locale } = state.settings;
+    // $FlowIgnore[incompatible-type]: `locale` renamed to `language` in 31
+    const locale: string = state.settings.locale;
     const newLocale = newLocaleNames[locale] ?? locale;
     // $FlowIgnore[prop-missing]
     return {
@@ -244,7 +245,8 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
   // Rename locale `id-ID` back to `id`.
   '26': state => {
     // $FlowIgnore[prop-missing]: `locale` renamed to `language` in 31
-    const { locale } = state.settings;
+    // $FlowIgnore[incompatible-type]: `locale` renamed to `language` in 31
+    const locale: string = state.settings.locale;
     const newLocale = locale === 'id-ID' ? 'id' : locale;
     // $FlowIgnore[prop-missing]
     return {
@@ -299,12 +301,13 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
   // Rename to `state.settings.language` from `state.settings.locale`.
   '31': state => {
     // $FlowIgnore[prop-missing]: migration fudge
-    const { locale: language, ...settingsRest } = state.settings;
+    const { locale, ...settingsRest } = state.settings;
     return {
       ...state,
       settings: {
         ...settingsRest,
-        language,
+        // $FlowIgnore[incompatible-cast] - is string when migration runs
+        language: (locale: string),
       },
     };
   },
@@ -455,7 +458,11 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
       ...state,
       settings: {
         ...restSettings,
-        markMessagesReadOnScroll: (doNotMarkMessagesAsRead: boolean) ? 'never' : 'always',
+        markMessagesReadOnScroll:
+          // $FlowIgnore[incompatible-cast] - is boolean when migration runs
+          (doNotMarkMessagesAsRead: boolean)
+            ? 'never' // newline to narrow FlowIgnore's scope, above
+            : 'always',
       },
     };
   },

yarn.lock

@@ -5837,10 +5837,10 @@ flow-annotation-check@^1.8.1:
     glob "7.1.6"
     load-pkg "^4.0.0"
 
-flow-bin@^0.170.0:
-  version "0.170.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.170.0.tgz#1da264de9868cc20a338f801bedc370e3e06f5cc"
-  integrity sha512-h4qy4f5loKdeLhj7TRM6XQWhmPpnfjDcOg6GPDuJnLAQuB60LJIHZ8QL3hxMf0oA++NkiYx62Vr8oHu+UZ2bGQ==
+flow-bin@^0.175.1:
+  version "0.175.1"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.175.1.tgz#72237070ba4f293f9e04113481e18929c1de50df"
+  integrity sha512-zMCP0BPa9BrfBSR7QTcyT/XBwzUbyLdNG0eXvBuNxfHCbMRkUzSceRoOaEZIw+R+GH0UHjVfUvPJ30hXxz1Nfw==
 
 flow-coverage-report@^0.8.0:
   version "0.8.0"