presence tests: Start type-checking; use example data

Author: chrisbobbe

src/presence/__tests__/presenceReducer-test.js

@@ -1,11 +1,9 @@
+/* @flow strict-local */
+
 import deepFreeze from 'deep-freeze';
 
-import {
-  REGISTER_COMPLETE,
-  PRESENCE_RESPONSE,
-  EVENT_PRESENCE,
-  ACCOUNT_SWITCH,
-} from '../../actionConstants';
+import * as eg from '../../__tests__/lib/exampleData';
+import { PRESENCE_RESPONSE, EVENT_PRESENCE } from '../../actionConstants';
 import presenceReducer from '../presenceReducer';
 
 const currentTimestamp = Date.now() / 1000;
@@ -19,13 +17,8 @@ describe('presenceReducer', () => {
           website: { client: 'website', status: 'active', timestamp: 123 },
         },
       };
-      const prevState = deepFreeze({});
-      const action = deepFreeze({
-        type: REGISTER_COMPLETE,
-        data: {
-          presences: presenceData,
-        },
-      });
+      const prevState = deepFreeze(eg.baseReduxState.presence);
+      const action = eg.mkActionRegisterComplete({ presences: presenceData });
 
       const actualState = presenceReducer(prevState, action);
 
@@ -40,9 +33,15 @@ describe('presenceReducer', () => {
           website: { client: 'website', status: 'active', timestamp: 123 },
         },
       });
-      const action = deepFreeze({
-        type: REGISTER_COMPLETE,
-        data: {},
+      const action = eg.mkActionRegisterComplete({
+        // Hmm, we should need a Flow suppression here. This property is
+        // marked required in InitialData, and this explicit undefined is
+        // meant to defy that; see TODO(#5102) above.
+        // mkActionRegisterComplete is designed to accept input with this or
+        // any property *omitted*… and I think, as a side effect of handling
+        // that, Flow mistakenly accepts an explicit undefined here, so it
+        // doesn't catch the resulting malformed InitialData.
+        presences: undefined,
       });
       const expectedState = {};
 
@@ -56,8 +55,8 @@ describe('presenceReducer', () => {
     test('merges a single user in presence response', () => {
       const presence = {
         '[email protected]': {
-          aggregated: { status: 'active', timestamp: 123 },
-          website: { status: 'active', timestamp: 123 },
+          aggregated: { status: 'active', timestamp: 123, client: 'website' },
+          website: { status: 'active', timestamp: 123, client: 'website' },
         },
       };
       const action = deepFreeze({
@@ -67,15 +66,13 @@ describe('presenceReducer', () => {
       });
 
       const prevState = deepFreeze({
-        '[email protected]': {},
-      });
-
-      const expectedState = {
         '[email protected]': {
-          aggregated: { status: 'active', timestamp: 123 },
-          website: { status: 'active', timestamp: 123 },
+          aggregated: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+          zulipMobile: { status: 'active', timestamp: 8, client: 'zulipMobile' },
         },
-      };
+      });
+
+      const expectedState = { ...prevState, ...presence };
 
       const newState = presenceReducer(prevState, action);
 
@@ -84,8 +81,14 @@ describe('presenceReducer', () => {
 
     test('merges multiple users in presence response', () => {
       const prevState = deepFreeze({
-        '[email protected]': {},
-        '[email protected]': {},
+        '[email protected]': {
+          aggregated: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+          zulipMobile: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+        },
+        '[email protected]': {
+          aggregated: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+          zulipMobile: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+        },
       });
 
       const presence = {
@@ -94,11 +97,8 @@ describe('presenceReducer', () => {
           website: { client: 'website', status: 'active', timestamp: 123 },
         },
         '[email protected]': {
-          website: {
-            status: 'active',
-            timestamp: 345,
-            client: 'website',
-          },
+          aggregated: { status: 'active', timestamp: 345, client: 'website' },
+          website: { status: 'active', timestamp: 345, client: 'website' },
         },
       };
       const action = deepFreeze({
@@ -107,20 +107,7 @@ describe('presenceReducer', () => {
         serverTimestamp: 12345,
       });
 
-      const expectedState = {
-        '[email protected]': {
-          aggregated: { client: 'website', status: 'active', timestamp: 123 },
-          website: { client: 'website', status: 'active', timestamp: 123 },
-        },
-        '[email protected]': {
-          website: {
-            status: 'active',
-            timestamp: 345,
-            client: 'website',
-          },
-        },
-        '[email protected]': {},
-      };
+      const expectedState = { ...prevState, ...presence };
 
       const newState = presenceReducer(prevState, action);
 
@@ -138,13 +125,15 @@ describe('presenceReducer', () => {
             timestamp: currentTimestamp - 20,
           },
           website: {
+            client: 'website',
             status: 'idle',
             timestamp: currentTimestamp - 20,
           },
         },
       });
 
       const action = deepFreeze({
+        id: 1,
         type: EVENT_PRESENCE,
         email: '[email protected]',
         server_timestamp: 200,
@@ -165,6 +154,7 @@ describe('presenceReducer', () => {
             timestamp: currentTimestamp - 10,
           },
           website: {
+            client: 'website',
             status: 'idle',
             timestamp: currentTimestamp - 20,
           },
@@ -184,18 +174,15 @@ describe('presenceReducer', () => {
 
   describe('ACCOUNT_SWITCH', () => {
     test('resets state to initial state', () => {
-      const prevState = deepFreeze([
-        {
-          full_name: 'Some Guy',
-          email: '[email protected]',
-          status: 'offline',
+      const prevState = deepFreeze({
+        '[email protected]': {
+          aggregated: { status: 'active', timestamp: 8, client: 'zulipMobile' },
+          zulipMobile: { status: 'active', timestamp: 8, client: 'zulipMobile' },
         },
-      ]);
-
-      const action = deepFreeze({
-        type: ACCOUNT_SWITCH,
       });
 
+      const action = eg.action.account_switch;
+
       const expectedState = {};
 
       const actualState = presenceReducer(prevState, action);