Skip to content

Commit 6082f4f

Browse files
committed
msglist [nfc]: Move implementation details of assetsUrl out of jsdoc
1 parent c7f97b0 commit 6082f4f

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

src/webview/MessageList.js

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -75,21 +75,20 @@ export type Props = $ReadOnly<{|
7575

7676
/**
7777
* The URL of the platform-specific assets folder.
78-
*
79-
* - On iOS: We can't easily hardcode this because it includes UUIDs.
80-
* So we bring it over the React Native bridge in ZLPConstants.m.
81-
*
82-
* - On Android: Different apps' WebViews see different (virtual) root
83-
* directories as `file:///`, and in particular the WebView provides
84-
* the APK's `assets/` directory as `file:///android_asset/`. [1]
85-
* We can easily hardcode that, so we do.
86-
*
87-
* [1] Oddly, this essential feature doesn't seem to be documented! It's
88-
* widely described in how-tos across the web and StackOverflow answers.
89-
* It's assumed in some related docs which mention it in passing, and
90-
* treated matter-of-factly in some Chromium bug threads. Details at:
91-
* https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/android.20filesystem/near/796440
9278
*/
79+
// - On iOS: We can't easily hardcode this because it includes UUIDs.
80+
// So we bring it over the React Native bridge in ZLPConstants.m.
81+
//
82+
// - On Android: Different apps' WebViews see different (virtual) root
83+
// directories as `file:///`, and in particular the WebView provides
84+
// the APK's `assets/` directory as `file:///android_asset/`. [1]
85+
// We can easily hardcode that, so we do.
86+
//
87+
// [1] Oddly, this essential feature doesn't seem to be documented! It's
88+
// widely described in how-tos across the web and StackOverflow answers.
89+
// It's assumed in some related docs which mention it in passing, and
90+
// treated matter-of-factly in some Chromium bug threads. Details at:
91+
// https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/android.20filesystem/near/796440
9392
const assetsUrl =
9493
Platform.OS === 'ios'
9594
? new URL(NativeModules.ZLPConstants.resourceURL)

0 commit comments

Comments
 (0)