Skip to content

Commit 61dcfa8

Browse files
chrisbobbegnprice
authored andcommitted
msglist diffing tests [nfc]: Comment about msgWithChoice's .submessages
For where we got the 1.9 threshold, see https://chat.zulip.org/#narrow/stream/412-api-documentation/topic/.60.2Esubmessages.60.20on.20message.20objects/near/1358489
1 parent 67ef5d6 commit 61dcfa8

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/api/modelTypes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,8 @@ type MessageBase = $ReadOnly<{|
623623
sender_realm_str: string,
624624
sender_short_name: string,
625625

626-
/** Older servers omit this; when omitted, equivalent to empty array. */
626+
/** Servers <1.9.0 omit this; when omitted, equivalent to empty array. */
627+
// TODO(server-1.9): Make required.
627628
submessages?: $ReadOnlyArray<Submessage>,
628629

629630
timestamp: number,

src/webview/__tests__/generateInboundEventEditSequence-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,10 @@ describe('getEditSequence correct for interesting changes', () => {
842842
const msgWithVote = {
843843
...baseMessage,
844844
submessages: [
845+
// Flow v0.149 will invalidate a refinement that `.submessages` is
846+
// present. We can assert it's present with `invariant` in an
847+
// IIFE, or use a $FlowFixMe
848+
// TODO(server-1.9): No special treatment needed.
845849
...msgWithChoice.submessages,
846850
{
847851
...baseSubmessage,

0 commit comments

Comments
 (0)