realm state: Store presenceEnabled

Author: chrisbobbe

src/realm/__tests__/realmReducer-test.js

@@ -91,6 +91,8 @@ describe('realmReducer', () => {
         /* $FlowIgnore[incompatible-use] - testing modern servers, which
            send user_settings. */
         twentyFourHourTime: action.data.user_settings.twenty_four_hour_time,
+        // $FlowIgnore[incompatible-use] - see above
+        presenceEnabled: action.data.user_settings.presence_enabled,
 
         //
         // Misc.: Not in the /register response. (These should be unchanged.)
@@ -330,6 +332,14 @@ describe('realmReducer', () => {
         check(false, true);
         check(false, false);
       });
+
+      describe('presenceEnabled / presence_enabled', () => {
+        const check = mkCheck('presenceEnabled', 'presence_enabled');
+        check(true, true);
+        check(true, false);
+        check(false, true);
+        check(false, false);
+      });
     });
 
     describe('type `realm`, op `update_dict`', () => {

src/realm/realmReducer.js

@@ -75,6 +75,7 @@ const initialState = {
   //
 
   twentyFourHourTime: false,
+  presenceEnabled: false,
 
   //
   // Misc.: Not in the /register response.
@@ -194,6 +195,11 @@ export default (
           /* $FlowIgnore[incompatible-cast]: If `user_settings` is absent,
              this will be present. */
           ?? (action.data.twenty_four_hour_time: boolean),
+
+        // Let this be null for servers that don't support the
+        // user_settings_object client capability. Support begins at FL 89,
+        // and we currently don't need this value when the server is pre-89.
+        presenceEnabled: action.data.user_settings?.presence_enabled ?? null,
       };
     }
 
@@ -300,6 +306,10 @@ export default (
                 // $FlowFixMe[incompatible-cast] - fix UserSettingsUpdateEvent
                 return { ...state, twentyFourHourTime: (value: boolean) };
               }
+              case 'presence_enabled': {
+                // $FlowFixMe[incompatible-cast] - fix UserSettingsUpdateEvent
+                return { ...state, presenceEnabled: (value: boolean) };
+              }
 
               default:
                 return state;

src/reduxTypes.js

@@ -335,6 +335,13 @@ export type RealmState = {|
 
   +twentyFourHourTime: boolean,
 
+  // We let this be null if `user_settings` isn't supported, just because we
+  // don't currently need the value for pre-FL 89 servers. If we start
+  // needing it, we can fall back to the deprecated `presence_enabled`
+  // directly on the /register response.
+  // TODO(server-5.0): user_settings supported in FL 89; remove null case
+  +presenceEnabled: boolean | null,
+
   //
   // Misc.: Not in the /register response.
   //

src/storage/__tests__/migrations-test.js

@@ -104,7 +104,7 @@ describe('migrations', () => {
   // What `base` becomes after all migrations.
   const endBase = {
     ...base52,
-    migrations: { version: 55 },
+    migrations: { version: 56 },
   };
 
   for (const [desc, before, after] of [
@@ -127,9 +127,9 @@ describe('migrations', () => {
     // redundant with this one, because none of the migration steps notice
     // whether any properties outside `storeKeys` are present or not.
     [
-      'check dropCache at 55',
+      'check dropCache at 56',
       // Just before the `dropCache`, plus a `cacheKeys` property, plus junk.
-      { ...base52, migrations: { version: 54 }, mute: [], nonsense: [1, 2, 3] },
+      { ...base52, migrations: { version: 55 }, mute: [], nonsense: [1, 2, 3] },
       // Should wind up with the same result as without the extra properties.
       endBase,
     ],

src/storage/migrations.js

@@ -469,6 +469,9 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
   // Drop old never-used message flags from state.flags.
   '55': dropCache,
 
+  // Add presenceEnabled to state.realm.
+  '56': dropCache,
+
   // TIP: When adding a migration, consider just using `dropCache`.
   //   (See its jsdoc for guidance on when that's the right answer.)
 };