presence: Use server's offline threshold in getPresenceOnlyStatusForUser

Fixes: #5669

Author: gnprice

src/presence/__tests__/presenceModel-test.js

@@ -243,6 +243,22 @@ describe('getPresenceOnlyStatusForUser', () => {
     ).toBe('idle');
   });
 
+  test('Use specified offline threshold', () => {
+    const userPresence = {
+      aggregated: {
+        client: 'website',
+        status: 'idle',
+        timestamp: Math.trunc(Date.now() / 1000 - 60), // 1 minute
+      },
+    };
+    expect(
+      getPresenceOnlyStatusForUser(
+        makePresenceState([[eg.otherUser, userPresence]], { offlineThresholdSeconds: 40 }),
+        eg.otherUser,
+      ),
+    ).toBe('offline');
+  });
+
   test('if status is not "offline" and last activity was less than 5min ago result is "active"', () => {
     const userPresence = {
       aggregated: {

src/presence/presenceModel.js

@@ -54,9 +54,6 @@ const presenceStatusGeq = (a: PresenceStatus, b: PresenceStatus): boolean => {
   }
 };
 
-// TODO(#5669): get OFFLINE_THRESHOLD_SECS from PresenceState
-const OFFLINE_THRESHOLD_SECS = 140;
-
 /**
  * Aggregate our information on a user's presence across their clients.
  *
@@ -165,7 +162,7 @@ export function getPresenceOnlyStatusForUser(
   const timestampDate = new Date(timestamp * 1000);
   const diffToNowInSeconds = differenceInSeconds(Date.now(), timestampDate);
 
-  if (diffToNowInSeconds > OFFLINE_THRESHOLD_SECS) {
+  if (diffToNowInSeconds > state.offlineThresholdSeconds) {
     return 'offline';
   }