Skip to content

Commit b55d0b3

Browse files
committed
Centerer [nfc]: Add TODO to delete
And write in a code comment something we noticed in review of #4868 ("Centerer: Remove, as unnecessary") about how we might like `Screen` to work. With this, I plan to close #4868. It's stale, and when looking through my open PRs, it takes more attention than it deserves.
1 parent 49ed2ef commit b55d0b3

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/common/Centerer.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ type Props = $ReadOnly<{|
3333
* @prop children - Components to be centered.
3434
* @prop [padding] - Specifies if the components should be padded.
3535
*/
36+
// TODO: Remove this component. Callers should be more transparent about
37+
// what they want, especially if that includes setting things unrelated to
38+
// centering, like `maxWidth: 480`.
3639
export default class Centerer extends PureComponent<Props> {
3740
static defaultProps: {| padding: boolean |} = {
3841
padding: false,

src/common/Screen.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ export default function Screen(props: Props): Node {
9090
centerContent: {
9191
flexGrow: 1,
9292
justifyContent: 'center',
93+
// TODO: decide whether to add `alignItems: 'center'`:
94+
// https://github.com/zulip/zulip-mobile/pull/4868#discussion_r665486501
9395
},
9496
padding: {
9597
padding: 16,

0 commit comments

Comments
 (0)