internalLinks [nfc]: Have getNarrowFromLink take URL object

Author: chrisbobbe

src/message/messagesActions.js

@@ -222,7 +222,13 @@ export const messageLinkPress =
     const streamsById = getStreamsById(state);
     const streamsByName = getStreamsByName(state);
     const ownUserId = getOwnUserId(state);
-    const narrow = getNarrowFromLink(href, auth.realm, streamsById, streamsByName, ownUserId);
+    const narrow = getNarrowFromLink(
+      new URL(href, auth.realm), // TODO: Use parsedUrl, below.
+      auth.realm,
+      streamsById,
+      streamsByName,
+      ownUserId,
+    );
 
     const parsedUrl = tryParseUrl(href, auth.realm);
     // TODO: Replace all uses of `href` below with `parsedUrl`.

src/utils/__tests__/internalLinks-test.js

@@ -198,9 +198,10 @@ describe('getNarrowFromLink', () => {
 
   const streamGeneral = eg.makeStream({ name: 'general' });
 
+  // TODO: Take URL object instead of string
   const get = (url, streams: $ReadOnlyArray<Stream>) =>
     getNarrowFromLink(
-      url,
+      new URL(url, 'https://example.com'),
       new URL('https://example.com'),
       new Map(streams.map(s => [s.stream_id, s])),
       new Map(streams.map(s => [s.name, s])),

src/utils/internalLinks.js

@@ -155,29 +155,22 @@ const parsePmOperand = operand => {
 
 /**
  * TODO write jsdoc
- *
- * This performs a call to `new URL` and therefore may take a fraction of a
- * millisecond.  Avoid using in a context where it might be called more than
- * 10 or 100 times per user action.
  */
 export const getNarrowFromLink = (
-  url: string,
+  url: URL,
   realm: URL,
   streamsById: Map<number, Stream>,
   streamsByName: Map<string, Stream>,
   ownUserId: UserId,
 ): Narrow | null => {
-  // TODO: Get this from caller
-  const parsedUrl = new URL(url, realm);
-
-  const type = getLinkType(parsedUrl, realm);
+  const type = getLinkType(url, realm);
 
   if (type === 'non-narrow') {
     return null;
   }
 
   // isNarrowLink(…) is true, by early return above, so this call is OK.
-  const hashSegments = getHashSegmentsFromNarrowLink(parsedUrl, realm);
+  const hashSegments = getHashSegmentsFromNarrowLink(url, realm);
 
   switch (type) {
     case 'pm': {