api: Log to Sentry when refusing to connect to an ancient server

And, since we'll be logging `ServerTooOldError`s to Sentry, change
the error message to use `.coarse` instead of `.raw`, since at least
when the version has a Git commit ID in it, we expect `.raw` would
cause the logs to get split up into a bunch of different issues for
different commit IDs.

Author: chrisbobbe

src/api/apiErrors.js

@@ -183,12 +183,17 @@ export const kMinAllowedServerVersion: ZulipVersion = new ZulipVersion('2.0');
 
 /**
  * An error we throw in API bindings on finding a server is too old.
+ *
+ * Handling code should:
+ * - refuse to interact with the server except to check if it's been updated
+ * - log out the user
+ * - log to Sentry (so we have a sense of how often this happens)
  */
 export class ServerTooOldError extends ExtendableError {
   version: ZulipVersion;
 
   constructor(version: ZulipVersion) {
-    super(`Unsupported Zulip Server version: ${version.raw()}`);
+    super(`Unsupported Zulip Server version: ${version.classify().coarse}`);
     this.version = version;
   }
 }

src/events/eventActions.js

@@ -26,6 +26,7 @@ import {
   Server5xxError,
   NetworkError,
   ServerTooOldError,
+  kMinAllowedServerVersion,
 } from '../api/apiErrors';
 import * as logging from '../utils/logging';
 import { showErrorAlert } from '../utils/info';
@@ -178,6 +179,12 @@ export const registerAndStartPolling =
             globalSettings: getGlobalSettings(),
           },
         );
+        logging.setTagsFromServerVersion(e.version);
+        logging.error(e, {
+          kMinAllowedServerVersion: kMinAllowedServerVersion.raw(),
+          kMinSupportedVersion: kMinSupportedVersion.raw(),
+          kNextMinSupportedVersion: kNextMinSupportedVersion.raw(),
+        });
         // Don't delay the logout action by awaiting this request: it may
         // take a long time or never succeed, and we need to kick the user
         // out immediately.

src/message/fetchActions.js

@@ -18,6 +18,7 @@ import {
   ApiError,
   MalformedResponseError,
   ServerTooOldError,
+  kMinAllowedServerVersion,
 } from '../api/apiErrors';
 import {
   getAuth,
@@ -41,7 +42,7 @@ import { ALL_PRIVATE_NARROW, apiNarrowOfNarrow, caseNarrow, topicNarrow } from '
 import { BackoffMachine, promiseTimeout, TimeoutError } from '../utils/async';
 import { getAllUsersById, getOwnUserId } from '../users/userSelectors';
 import type { ServerSettings } from '../api/settings/getServerSettings';
-import { kMinSupportedVersion } from '../common/ServerCompatBanner';
+import { kMinSupportedVersion, kNextMinSupportedVersion } from '../common/ServerCompatBanner';
 
 const messageFetchStart = (
   narrow: Narrow,
@@ -444,6 +445,12 @@ export async function fetchServerSettings(realm: URL): Promise<
           'https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#compatibility-and-upgrading',
         ),
       };
+      logging.setTagsFromServerVersion(error.version);
+      logging.error(error, {
+        kMinAllowedServerVersion: kMinAllowedServerVersion.raw(),
+        kMinSupportedVersion: kMinSupportedVersion.raw(),
+        kNextMinSupportedVersion: kNextMinSupportedVersion.raw(),
+      });
     } else if (error instanceof MalformedResponseError && error.httpStatus === 404) {
       message = {
         text: 'The server at {realm} does not seem to be a Zulip server.',