rename night mode to dark theme

Author: aritroCoder

src/reduxTypes.js

@@ -372,7 +372,7 @@ export type ThemeName = 'light' | 'dark';
  * To determine the actual theme to show the user, use a ThemeName;
  * see there for details.
  */
-export type ThemeSetting = 'default' | 'night';
+export type ThemeSetting = 'default' | 'dark';
 
 /** What browser the user has set to use for opening links in messages.
  *

src/settings/SettingsScreen.js

@@ -35,12 +35,12 @@ export default function SettingsScreen(props: Props): Node {
   const { navigation } = props;
 
   const handleThemeChange = useCallback(() => {
-    dispatch(setGlobalSettings({ theme: theme === 'default' ? 'night' : 'default' }));
+    dispatch(setGlobalSettings({ theme: theme === 'default' ? 'dark' : 'default' }));
   }, [theme, dispatch]);
 
   return (
     <Screen title="Settings">
-      <SwitchRow label="Dark theme" value={theme === 'night'} onValueChange={handleThemeChange} />
+      <SwitchRow label="Dark theme" value={theme === 'dark'} onValueChange={handleThemeChange} />
       <SwitchRow
         label="Open links with in-app browser"
         value={shouldUseInAppBrowser(browser)}

src/settings/__tests__/settingsReducer-test.js

@@ -79,12 +79,12 @@ describe('settingsReducer', () => {
     test('changes value of a key', () => {
       const action = deepFreeze({
         type: SET_GLOBAL_SETTINGS,
-        update: { theme: 'night' },
+        update: { theme: 'dark' },
       });
 
       const expectedState = {
         ...baseState,
-        theme: 'night',
+        theme: 'dark',
       };
 
       const actualState = settingsReducer(baseState, action);

src/storage/__tests__/migrations-test.js

@@ -104,7 +104,7 @@ describe('migrations', () => {
   // What `base` becomes after all migrations.
   const endBase = {
     ...base52,
-    migrations: { version: 56 },
+    migrations: { version: 57 },
   };
 
   for (const [desc, before, after] of [
@@ -278,6 +278,20 @@ describe('migrations', () => {
       },
       { ...endBase, settings: { ...endBase.settings, markMessagesReadOnScroll: 'never' } },
     ],
+    [
+      "check 57 with 'night'",
+      { ...base52, migrations: { version: 56 }, settings: { ...base52.settings, theme: 'night' } },
+      { ...endBase, settings: { ...endBase.settings, theme: 'dark' } },
+    ],
+    [
+      "check 57 with 'default'",
+      {
+        ...base52,
+        migrations: { version: 56 },
+        settings: { ...base52.settings, theme: 'default' },
+      },
+      { ...endBase, settings: { ...endBase.settings, theme: 'default' } },
+    ],
   ]) {
     /* eslint-disable no-loop-func */
     test(desc, async () => {

src/storage/migrations.js

@@ -472,6 +472,12 @@ const migrationsInner: {| [string]: (LessPartialState) => LessPartialState |} =
   // Add presenceEnabled to state.realm.
   '56': dropCache,
 
+  // Rename 'night' to 'dark' in state.settings.theme
+  '57': state => ({
+    ...state,
+    settings: { ...state.settings, theme: state.settings.theme === 'night' ? 'dark' : 'default' },
+  }),
+
   // TIP: When adding a migration, consider just using `dropCache`.
   //   (See its jsdoc for guidance on when that's the right answer.)
 };

static/translations/messages_ar.json

@@ -157,7 +157,7 @@
   "Learn more": "تعرف على المزيد",
   "Full profile": "Full profile",
   "Settings": "Settings",
-  "Dark theme": "الوضع الليلي",
+  "Night mode": "الوضع الليلي",
   "Open links with in-app browser": "افتح الروابط باستخدام متصفح داخل التطبيق",
   "Language": "لغة",
   "Arabic": "عربي",

static/translations/messages_bg.json

@@ -157,7 +157,7 @@
   "Learn more": "Learn more",
   "Full profile": "Full profile",
   "Settings": "Настройки",
-  "Dark theme": "Нощен режим",
+  "Night mode": "Нощен режим",
   "Open links with in-app browser": "Open links with in-app browser",
   "Language": "Език",
   "Arabic": "Arabic",

static/translations/messages_bn.json

@@ -157,7 +157,7 @@
   "Learn more": "Learn more",
   "Full profile": "Full profile",
   "Settings": "সেটিংস",
-  "Dark theme": "Dark theme",
+  "Night mode": "Night mode",
   "Open links with in-app browser": "Open links with in-app browser",
   "Language": "Language",
   "Arabic": "Arabic",

static/translations/messages_ca.json

@@ -157,7 +157,7 @@
   "Learn more": "Més informació",
   "Full profile": "Full profile",
   "Settings": "Configuració",
-  "Dark theme": "Mode nocturn",
+  "Night mode": "Mode nocturn",
   "Open links with in-app browser": "Obre els enllaços en el navegador intern",
   "Language": "Llengua",
   "Arabic": "Àrab",

static/translations/messages_cs.json

@@ -157,7 +157,7 @@
   "Learn more": "Dozvědět se více",
   "Full profile": "Celý profil",
   "Settings": "Nastavení",
-  "Dark theme": "Noční režim",
+  "Night mode": "Noční režim",
   "Open links with in-app browser": "Otevírat odkazy v zabudovaném prohlížeči",
   "Language": "Jazyk",
   "Arabic": "Arabština",