internalLinks [nfc]: Have getNearOperandFromLink take URL object

Author: chrisbobbe

src/message/messagesActions.js

@@ -240,7 +240,7 @@ export const messageLinkPress =
     //   which should be futile.
     if (narrow) {
       // This call is OK: `narrow` is truthy, so isNarrowLink(…) was true.
-      const nearOperand = getNearOperandFromLink(href, auth.realm);
+      const nearOperand = getNearOperandFromLink(parsedUrl, auth.realm);
       if (nearOperand === null) {
         dispatch(doNarrow(narrow));
         return;

src/utils/__tests__/internalLinks-test.js

@@ -371,23 +371,23 @@ describe('getNarrowFromLink', () => {
 
 describe('getNearOperandFromLink', () => {
   test('not message link', () => {
-    expect(getNearOperandFromLink('https://example.com/#narrow/is/private', realm)).toBe(null);
-    expect(getNearOperandFromLink('https://example.com/#narrow/stream/jest', realm)).toBe(null);
+    expect(getNearOperandFromLink(new URL('/#narrow/is/private', realm), realm)).toBe(null);
+    expect(getNearOperandFromLink(new URL('/#narrow/stream/jest', realm), realm)).toBe(null);
   });
 
   test('`near` is the only operator', () => {
-    expect(getNearOperandFromLink('https://example.com/#narrow/near/1', realm)).toBe(1);
+    expect(getNearOperandFromLink(new URL('/#narrow/near/1', realm), realm)).toBe(1);
   });
 
   test('when link is a group link, return anchor message id', () => {
     expect(
-      getNearOperandFromLink('https://example.com/#narrow/pm-with/1,3-group/near/1/', realm),
+      getNearOperandFromLink(new URL('/#narrow/pm-with/1,3-group/near/1/', realm), realm),
     ).toBe(1);
   });
 
   test('when link is a topic link, return anchor message id', () => {
     expect(
-      getNearOperandFromLink('https://example.com/#narrow/stream/jest/topic/test/near/1', realm),
+      getNearOperandFromLink(new URL('/#narrow/stream/jest/topic/test/near/1', realm), realm),
     ).toBe(1);
   });
 });

src/utils/internalLinks.js

@@ -207,17 +207,10 @@ export const getNarrowFromLink = (
 /**
  * From a URL and realm with `isNarrowLink(url, realm) === true`, give
  *   message_id if the URL has /near/{message_id}, otherwise give null.
- *
- * This performs a call to `new URL` and therefore may take a fraction of a
- * millisecond.  Avoid using in a context where it might be called more than
- * 10 or 100 times per user action.
  */
-export const getNearOperandFromLink = (url: string, realm: URL): number | null => {
-  // TODO: Get this from caller
-  const parsedUrl = new URL(url, realm);
-
+export const getNearOperandFromLink = (url: URL, realm: URL): number | null => {
   // isNarrowLink(…) is true, by jsdoc, so this call is OK.
-  const hashSegments = getHashSegmentsFromNarrowLink(parsedUrl, realm);
+  const hashSegments = getHashSegmentsFromNarrowLink(url, realm);
 
   // This and nearOperandIndex can simplify when we rename/repurpose
   //   getHashSegmentsFromNarrowLink so it gives an array of