internalLinks [nfc]: Rename getMessageIdFromLink to getNearOperandFromLink

Author: chrisbobbe

src/message/messagesActions.js

@@ -2,7 +2,7 @@
 import * as NavigationService from '../nav/NavigationService';
 import type { Narrow, ThunkAction } from '../types';
 import { getAuth } from '../selectors';
-import { getMessageIdFromLink, getNarrowFromLink } from '../utils/internalLinks';
+import { getNearOperandFromLink, getNarrowFromLink } from '../utils/internalLinks';
 import { openLinkWithUserPreference } from '../utils/openLink';
 import { navigateToChat } from '../nav/navActions';
 import { FIRST_UNREAD_ANCHOR } from '../anchor';
@@ -37,8 +37,8 @@ export const messageLinkPress =
     //   which should be futile.
     if (narrow) {
       // This call is OK: `narrow` is truthy, so isNarrowLink(…) was true.
-      const anchor = getMessageIdFromLink(href, auth.realm);
-      dispatch(doNarrow(narrow, anchor));
+      const nearOperand = getNearOperandFromLink(href, auth.realm);
+      dispatch(doNarrow(narrow, nearOperand));
     } else if (!isUrlOnRealm(href, auth.realm)) {
       openLinkWithUserPreference(href, getGlobalSettings());
     } else {

src/utils/__tests__/internalLinks-test.js

@@ -6,7 +6,7 @@ import {
   isNarrowLink,
   getLinkType,
   getNarrowFromLink,
-  getMessageIdFromLink,
+  getNearOperandFromLink,
   decodeHashComponent,
 } from '../internalLinks';
 import * as eg from '../../__tests__/lib/exampleData';
@@ -418,25 +418,25 @@ describe('getNarrowFromLink', () => {
   });
 });
 
-describe('getMessageIdFromLink', () => {
+describe('getNearOperandFromLink', () => {
   test('not message link', () => {
-    expect(getMessageIdFromLink('https://example.com/#narrow/is/private', realm)).toBe(0);
-    expect(getMessageIdFromLink('https://example.com/#narrow/stream/jest', realm)).toBe(0);
+    expect(getNearOperandFromLink('https://example.com/#narrow/is/private', realm)).toBe(0);
+    expect(getNearOperandFromLink('https://example.com/#narrow/stream/jest', realm)).toBe(0);
   });
 
   test('`near` is the only operator', () => {
-    expect(getMessageIdFromLink('https://example.com/#narrow/near/1', realm)).toBe(1);
+    expect(getNearOperandFromLink('https://example.com/#narrow/near/1', realm)).toBe(1);
   });
 
   test('when link is a group link, return anchor message id', () => {
     expect(
-      getMessageIdFromLink('https://example.com/#narrow/pm-with/1,3-group/near/1/', realm),
+      getNearOperandFromLink('https://example.com/#narrow/pm-with/1,3-group/near/1/', realm),
     ).toBe(1);
   });
 
   test('when link is a topic link, return anchor message id', () => {
     expect(
-      getMessageIdFromLink('https://example.com/#narrow/stream/jest/topic/test/near/1', realm),
+      getNearOperandFromLink('https://example.com/#narrow/stream/jest/topic/test/near/1', realm),
     ).toBe(1);
   });
 });

src/utils/internalLinks.js

@@ -233,7 +233,7 @@ export const getNarrowFromLink = (
  * millisecond.  Avoid using in a context where it might be called more than
  * 10 or 100 times per user action.
  */
-export const getMessageIdFromLink = (url: string, realm: URL): number => {
+export const getNearOperandFromLink = (url: string, realm: URL): number => {
   // isNarrowLink(…) is true, by jsdoc, so this call is OK.
   const hashSegments = getHashSegmentsFromNarrowLink(url, realm);