notif [nfc]: Have tryStopNotifications take an Account object

Like its friend sendPushToken, which makes the api.savePushToken
request.

This prepares for a fix for #3469, "Removing account from list
doesn't stop notifications", following the approach Greg outlined at
  #3469 (comment) .

Author: chrisbobbe

src/account-info/ProfileScreen.js

@@ -16,13 +16,14 @@ import { tryStopNotifications } from '../notification/notifTokens';
 import AccountDetails from './AccountDetails';
 import { getRealm } from '../directSelectors';
 import { getOwnUser, getOwnUserId } from '../users/userSelectors';
-import { getAuth, getIdentity, getZulipFeatureLevel } from '../account/accountsSelectors';
+import { getAuth, getAccount, getZulipFeatureLevel } from '../account/accountsSelectors';
 import { useNavigation } from '../react-navigation';
 import { showConfirmationDialog } from '../utils/info';
 import { OfflineNoticePlaceholder } from '../boot/OfflineNoticeProvider';
 import { getUserStatus } from '../user-statuses/userStatusesModel';
 import SwitchRow from '../common/SwitchRow';
 import * as api from '../api';
+import { identityOfAccount } from '../account/accountMisc';
 
 const styles = createStyleSheet({
   buttonRow: {
@@ -94,7 +95,8 @@ function SwitchAccountButton(props: {||}) {
 function LogoutButton(props: {||}) {
   const dispatch = useDispatch();
   const _ = useContext(TranslationContext);
-  const identity = useSelector(getIdentity);
+  const account = useSelector(getAccount);
+  const identity = identityOfAccount(account);
   return (
     <ZulipButton
       style={styles.button}
@@ -109,7 +111,7 @@ function LogoutButton(props: {||}) {
             values: { email: identity.email, realmUrl: identity.realm.toString() },
           },
           onPressConfirm: () => {
-            dispatch(tryStopNotifications());
+            dispatch(tryStopNotifications(account));
             dispatch(logout());
           },
           _,

src/notification/notifTokens.js

@@ -17,7 +17,6 @@ import type {
 } from '../types';
 import type { JSONable } from '../utils/jsonable';
 import * as api from '../api';
-import { getAuth } from '../selectors';
 import { getGlobalSession, getAccounts } from '../directSelectors';
 import { identityOfAccount, authOfAccount, identityOfAuth } from '../account/accountMisc';
 import { getAccount } from '../account/accountsSelectors';
@@ -230,9 +229,17 @@ export const handleDeviceToken =
 // your account, including notifications, even when you don't have the
 // device in your possession.  That's zulip/zulip#17939.
 export const tryStopNotifications =
-  (): ThunkAction<Promise<void>> => async (dispatch, getState) => {
-    const auth = getAuth(getState());
-    const { ackedPushToken } = getAccount(getState());
+  (account: Account): GlobalThunkAction<Promise<void>> & ThunkAction<Promise<void>> =>
+  // Why both GlobalThunkAction and ThunkAction?  Well, this function is
+  // per-account... but whereas virtually all our other per-account code is
+  // implicitly about the active account, this is about a specific account
+  // it's explicitly passed.  That makes it equally legitimate to call from
+  // per-account or global code.
+  // TODO(#5006): Once we have per-account states for all accounts, make
+  //   this an ordinary per-account action.
+  async dispatch => {
+    const auth = authOfAccount(account);
+    const { ackedPushToken } = account;
     if (ackedPushToken !== null) {
       dispatch(unackPushToken(identityOfAuth(auth)));
       try {