core/messages/views: Pass spoiler data to MsgInfoView popup helpers.

Tests amended.

Co-authored-by: Preet Mishra <[email protected]>
Co-authored-by: Ezio-Sarthak <[email protected]>

Author: 3 people

tests/ui_tools/test_popups.py

@@ -504,6 +504,7 @@ def mock_external_classes(self, mocker: MockerFixture, msg_box: MessageBox) -> N
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
             title="Full Rendered Message",
         )
 
@@ -514,6 +515,7 @@ def test_init(self, msg_box: MessageBox) -> None:
         assert self.full_rendered_message.topic_links == OrderedDict()
         assert self.full_rendered_message.message_links == OrderedDict()
         assert self.full_rendered_message.time_mentions == list()
+        assert self.full_rendered_message.spoilers == list()
         assert self.full_rendered_message.header.widget_list == msg_box.header
         assert self.full_rendered_message.footer.widget_list == msg_box.footer
 
@@ -556,6 +558,7 @@ def test_keypress_show_msg_info(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
 
 
@@ -580,6 +583,7 @@ def mock_external_classes(self, mocker: MockerFixture, msg_box: MessageBox) -> N
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
             title="Full Raw Message",
         )
 
@@ -590,6 +594,7 @@ def test_init(self, msg_box: MessageBox) -> None:
         assert self.full_raw_message.topic_links == OrderedDict()
         assert self.full_raw_message.message_links == OrderedDict()
         assert self.full_raw_message.time_mentions == list()
+        assert self.full_raw_message.spoilers == list()
         assert self.full_raw_message.header.widget_list == msg_box.header
         assert self.full_raw_message.footer.widget_list == msg_box.footer
 
@@ -632,6 +637,7 @@ def test_keypress_show_msg_info(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
 
 
@@ -655,6 +661,7 @@ def mock_external_classes(self, mocker: MockerFixture) -> None:
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
             title="Edit History",
         )
 
@@ -664,6 +671,7 @@ def test_init(self) -> None:
         assert self.edit_history_view.topic_links == OrderedDict()
         assert self.edit_history_view.message_links == OrderedDict()
         assert self.edit_history_view.time_mentions == list()
+        assert self.edit_history_view.spoilers == list()
         self.controller.model.fetch_message_history.assert_called_once_with(
             message_id=self.message["id"],
         )
@@ -703,6 +711,7 @@ def test_keypress_show_msg_info(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
 
     @pytest.mark.parametrize(
@@ -1019,13 +1028,15 @@ def mock_external_classes(
             OrderedDict(),
             OrderedDict(),
             list(),
+            list(),
         )
 
     def test_init(self, message_fixture: Message) -> None:
         assert self.msg_info_view.msg == message_fixture
         assert self.msg_info_view.topic_links == OrderedDict()
         assert self.msg_info_view.message_links == OrderedDict()
         assert self.msg_info_view.time_mentions == list()
+        assert self.msg_info_view.spoilers == list()
 
     def test_pop_up_info_order(self, message_fixture: Message) -> None:
         topic_links = OrderedDict([("https://bar.com", ("topic", 1, True))])
@@ -1037,6 +1048,7 @@ def test_pop_up_info_order(self, message_fixture: Message) -> None:
             topic_links=topic_links,
             message_links=message_links,
             time_mentions=list(),
+            spoilers=list(),
         )
         msg_links = msg_info_view.button_widgets
         assert msg_links == [message_links, topic_links]
@@ -1085,6 +1097,7 @@ def test_keypress_edit_history(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
         size = widget_size(msg_info_view)
 
@@ -1096,6 +1109,7 @@ def test_keypress_edit_history(
                 topic_links=OrderedDict(),
                 message_links=OrderedDict(),
                 time_mentions=list(),
+                spoilers=list(),
             )
         else:
             self.controller.show_edit_history.assert_not_called()
@@ -1114,6 +1128,7 @@ def test_keypress_full_rendered_message(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
         size = widget_size(msg_info_view)
 
@@ -1124,6 +1139,7 @@ def test_keypress_full_rendered_message(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
 
     @pytest.mark.parametrize("key", keys_for_command("FULL_RAW_MESSAGE"))
@@ -1140,6 +1156,7 @@ def test_keypress_full_raw_message(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
         size = widget_size(msg_info_view)
 
@@ -1150,6 +1167,7 @@ def test_keypress_full_raw_message(
             topic_links=OrderedDict(),
             message_links=OrderedDict(),
             time_mentions=list(),
+            spoilers=list(),
         )
 
     @pytest.mark.parametrize(
@@ -1251,6 +1269,7 @@ def test_height_reactions(
             OrderedDict(),
             OrderedDict(),
             list(),
+            list(),
         )
         # 12 = 7 labels + 2 blank lines + 1 'Reactions' (category)
         # + 4 reactions (excluding 'Message Links').

zulipterminal/core.py

@@ -265,6 +265,7 @@ def show_msg_info(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
     ) -> None:
         msg_info_view = MsgInfoView(
             self,
@@ -273,6 +274,7 @@ def show_msg_info(
             topic_links,
             message_links,
             time_mentions,
+            spoilers,
         )
         self.show_pop_up(msg_info_view, "area:msg")
 
@@ -343,6 +345,7 @@ def show_full_rendered_message(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
     ) -> None:
         self.show_pop_up(
             FullRenderedMsgView(
@@ -351,6 +354,7 @@ def show_full_rendered_message(
                 topic_links,
                 message_links,
                 time_mentions,
+                spoilers,
                 f"Full rendered message {SCROLL_PROMPT}",
             ),
             "area:msg",
@@ -362,6 +366,7 @@ def show_full_raw_message(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
     ) -> None:
         self.show_pop_up(
             FullRawMsgView(
@@ -370,6 +375,7 @@ def show_full_raw_message(
                 topic_links,
                 message_links,
                 time_mentions,
+                spoilers,
                 f"Full raw message {SCROLL_PROMPT}",
             ),
             "area:msg",
@@ -381,6 +387,7 @@ def show_edit_history(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
     ) -> None:
         self.show_pop_up(
             EditHistoryView(
@@ -389,6 +396,7 @@ def show_edit_history(
                 topic_links,
                 message_links,
                 time_mentions,
+                spoilers,
                 f"Edit History {SCROLL_PROMPT}",
             ),
             "area:msg",

zulipterminal/ui_tools/messages.py

@@ -1204,7 +1204,11 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
             self.model.controller.view.middle_column.set_focus("footer")
         elif is_command_key("MSG_INFO", key):
             self.model.controller.show_msg_info(
-                self.message, self.topic_links, self.message_links, self.time_mentions
+                self.message,
+                self.topic_links,
+                self.message_links,
+                self.time_mentions,
+                self.spoilers,
             )
         elif is_command_key("ADD_REACTION", key):
             self.model.controller.show_emoji_picker(self.message)

zulipterminal/ui_tools/views.py

@@ -1584,11 +1584,13 @@ def __init__(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
     ) -> None:
         self.msg = msg
         self.topic_links = topic_links
         self.message_links = message_links
         self.time_mentions = time_mentions
+        self.spoilers = spoilers
         self.server_url = controller.model.server_url
         date_and_time = controller.model.formatted_local_time(
             msg["timestamp"], show_seconds=True, show_year=True
@@ -1733,6 +1735,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
         elif is_command_key("VIEW_IN_BROWSER", key):
             url = near_message_url(self.server_url[:-1], self.msg)
@@ -1743,6 +1746,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
             return key
         elif is_command_key("FULL_RAW_MESSAGE", key):
@@ -1751,6 +1755,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
             return key
         return super().keypress(size, key)
@@ -1804,13 +1809,15 @@ def __init__(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
         self.topic_links = topic_links
         self.message_links = message_links
         self.time_mentions = time_mentions
+        self.spoilers = spoilers
         width = 64
         widgets: List[Any] = []
 
@@ -1909,6 +1916,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
             return key
         return super().keypress(size, key)
@@ -1922,13 +1930,15 @@ def __init__(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
         self.topic_links = topic_links
         self.message_links = message_links
         self.time_mentions = time_mentions
+        self.spoilers = spoilers
         max_cols, max_rows = controller.maximum_popup_dimensions()
 
         # Get rendered message
@@ -1953,6 +1963,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
             return key
         return super().keypress(size, key)
@@ -1966,13 +1977,15 @@ def __init__(
         topic_links: Dict[str, Tuple[str, int, bool]],
         message_links: Dict[str, Tuple[str, int, bool]],
         time_mentions: List[Tuple[str, str]],
+        spoilers: List[Tuple[int, List[Any], List[Any]]],
         title: str,
     ) -> None:
         self.controller = controller
         self.message = message
         self.topic_links = topic_links
         self.message_links = message_links
         self.time_mentions = time_mentions
+        self.spoilers = spoilers
         max_cols, max_rows = controller.maximum_popup_dimensions()
 
         # Get rendered message header and footer
@@ -2003,6 +2016,7 @@ def keypress(self, size: urwid_Size, key: str) -> str:
                 topic_links=self.topic_links,
                 message_links=self.message_links,
                 time_mentions=self.time_mentions,
+                spoilers=self.spoilers,
             )
             return key
         return super().keypress(size, key)