themes: Allow extra fields in META beyond those required.

Previously, the test for theme completeness required an exact match to
all required fields; this loosens that restriction to allow additional
optional fields.

Test updated.

Author: neiljp

tests/config/test_themes.py

@@ -113,6 +113,7 @@ def test_complete_and_incomplete_themes__bundled_theme_output() -> None:
         case({"META": None}, False, id="META_absent"),
         case({"META": {}}, False, id="META_empty"),
         case({"META": {"pygments": {}}}, False, id="META_pygments_empty"),
+        case({"META": "extra_field"}, True, id="META_with_extra_field"),
     ],
 )
 def test_complete_and_incomplete_themes__single_theme_completeness(
@@ -131,7 +132,7 @@ class FakeTheme:
         STYLES = {
             style: (FakeColor.COLOR_1, FakeColor.COLOR_2) for style in REQUIRED_STYLES
         }
-        META = {
+        META: Dict[str, Any] = {
             "pygments": {
                 "styles": None,
                 "background": None,
@@ -144,6 +145,8 @@ class FakeTheme:
     for field, action in missing.items():
         if action == "incomplete_style":
             setattr(FakeTheme, field, incomplete_style)
+        elif action == "extra_field":
+            FakeTheme.META["extra_field"] = 5  # Non-iterable misc data
         elif action is None:
             delattr(FakeTheme, field)
         else:

zulipterminal/config/themes.py

@@ -165,9 +165,9 @@ def complete_and_incomplete_themes() -> Tuple[List[str], List[str]]:
         if getattr(theme, "STYLES", None)
         if set(theme.STYLES) == set(REQUIRED_STYLES)
         if getattr(theme, "META", None)
-        if set(theme.META) == set(REQUIRED_META)
-        for meta, conf in theme.META.items()
-        if set(conf) == set(REQUIRED_META.get(meta, {}))
+        if set(theme.META).issuperset(set(REQUIRED_META))
+        for meta, conf in REQUIRED_META.items()
+        if set(conf) == set(theme.META.get(meta, {}))
     }
     incomplete = set(THEMES) - complete
     return sorted(complete), sorted(incomplete)