Skip to content

Commit 9e5036e

Browse files
committed
views: Delete the calling arguments from MsgInfoView's show_* calls.
Tests updated.
1 parent e316327 commit 9e5036e

File tree

2 files changed

+6
-30
lines changed

2 files changed

+6
-30
lines changed

tests/ui_tools/test_popups.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,10 +1014,7 @@ def test_keypress_edit_history(
10141014

10151015
if self.msg_info_view.show_edit_history_label:
10161016
self.controller.show_edit_history.assert_called_once_with(
1017-
message=self.message,
1018-
topic_links=OrderedDict(),
1019-
message_links=OrderedDict(),
1020-
time_mentions=list(),
1017+
message=self.message
10211018
)
10221019
else:
10231020
self.controller.show_edit_history.assert_not_called()
@@ -1031,10 +1028,7 @@ def test_keypress_full_rendered_message(
10311028
self.msg_info_view.keypress(size, key)
10321029

10331030
self.controller.show_full_rendered_message.assert_called_once_with(
1034-
message=self.message,
1035-
topic_links=OrderedDict(),
1036-
message_links=OrderedDict(),
1037-
time_mentions=list(),
1031+
message=self.message
10381032
)
10391033

10401034
@pytest.mark.parametrize("key", keys_for_command("FULL_RAW_MESSAGE"))
@@ -1046,10 +1040,7 @@ def test_keypress_full_raw_message(
10461040
self.msg_info_view.keypress(size, key)
10471041

10481042
self.controller.show_full_raw_message.assert_called_once_with(
1049-
message=self.message,
1050-
topic_links=OrderedDict(),
1051-
message_links=OrderedDict(),
1052-
time_mentions=list(),
1043+
message=self.message
10531044
)
10541045

10551046
@pytest.mark.parametrize(

zulipterminal/ui_tools/views.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,30 +1725,15 @@ def create_link_buttons(
17251725

17261726
def keypress(self, size: urwid_Size, key: str) -> str:
17271727
if is_command_key("EDIT_HISTORY", key) and self.show_edit_history_label:
1728-
self.controller.show_edit_history(
1729-
message=self.msg,
1730-
topic_links=self.topic_links,
1731-
message_links=self.message_links,
1732-
time_mentions=self.time_mentions,
1733-
)
1728+
self.controller.show_edit_history(message=self.msg)
17341729
elif is_command_key("VIEW_IN_BROWSER", key):
17351730
url = near_message_url(self.server_url[:-1], self.msg)
17361731
self.controller.open_in_browser(url)
17371732
elif is_command_key("FULL_RENDERED_MESSAGE", key):
1738-
self.controller.show_full_rendered_message(
1739-
message=self.msg,
1740-
topic_links=self.topic_links,
1741-
message_links=self.message_links,
1742-
time_mentions=self.time_mentions,
1743-
)
1733+
self.controller.show_full_rendered_message(message=self.msg)
17441734
return key
17451735
elif is_command_key("FULL_RAW_MESSAGE", key):
1746-
self.controller.show_full_raw_message(
1747-
message=self.msg,
1748-
topic_links=self.topic_links,
1749-
message_links=self.message_links,
1750-
time_mentions=self.time_mentions,
1751-
)
1736+
self.controller.show_full_raw_message(message=self.msg)
17521737
return key
17531738
return super().keypress(size, key)
17541739

0 commit comments

Comments
 (0)