refactor: Replace '_private' with '_direct' - rebased.

Author: Ajnus

tests/ui_tools/test_boxes.py

@@ -224,7 +224,7 @@ def test_not_calling_typing_method_to_oneself(
             )
 
     @pytest.mark.parametrize("key", keys_for_command("SEND_MESSAGE"))
-    def test_not_calling_send_private_message_without_recipients(
+    def test_not_calling_send_direct_message_without_recipients(
         self,
         key: str,
         mocker: MockerFixture,

tests/ui_tools/test_messages.py

@@ -71,7 +71,7 @@ def test_init_fails_with_bad_message_type(self):
         with pytest.raises(RuntimeError):
             MessageBox(message, self.model, None)
 
-    def test_direct_message_to_self(self, mocker):  # rebased
+    def test_direct_message_to_self(self, mocker):
         message = dict(
             type="private",
             display_recipient=[
@@ -85,14 +85,13 @@ def test_direct_message_to_self(self, mocker):  # rebased
         )
         self.model.user_email = "[email protected]"
         mocker.patch(
-            MODULE + ".MessageBox._is_direct_message_to_self",  # rebased
-            return_value=True,
+            MODULE + ".MessageBox._is_direct_message_to_self", return_value=True
         )
         mocker.patch.object(MessageBox, "main_view")
         msg_box = MessageBox(message, self.model, None)
 
         assert msg_box.recipient_emails == ["[email protected]"]
-        msg_box._is_direct_message_to_self.assert_called_once_with()  # rebased
+        msg_box._is_direct_message_to_self.assert_called_once_with()
 
     @pytest.mark.parametrize(
         "content, expected_markup",

zulipterminal/ui_tools/messages.py

@@ -88,7 +88,7 @@ def __init__(self, message: Message, model: "Model", last_message: Any) -> None:
             raise RuntimeError("Invalid message type")
 
         if self.message["type"] == "private":
-            if self._is_direct_message_to_self():  # rebased
+            if self._is_direct_message_to_self():
                 recipient = self.message["display_recipient"][0]
                 self.recipients_names = recipient["full_name"]
                 self.recipient_emails = [self.model.user_email]