Skip to content

Commit 9af0d08

Browse files
ntottenclaude
andcommitted
Use .nvmrc for Node version in CI and update dev devcontainer to Node 24
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 960afc7 commit 9af0d08

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.devcontainer/dev/base.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 22-bullseye, 18-bullseye, 16-bullseye, 14-bullseye, 22-buster, 18-buster, 16-buster, 14-buster
2-
ARG VARIANT=22-bullseye
1+
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 24-bullseye, 22-bullseye, 18-bullseye, 16-bullseye, 24-buster, 22-buster, 18-buster, 16-buster
2+
ARG VARIANT=24-bullseye
33
FROM node:${VARIANT}
44

55
# [Option] Install zsh

.devcontainer/dev/devcontainer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
"name": "Node.js",
55
"build": {
66
"dockerfile": "Dockerfile",
7-
// Update 'VARIANT' to pick a Node version: 22, 18, 16, 14.
7+
// Update 'VARIANT' to pick a Node version: 24, 22, 18, 16.
88
// Append -bullseye or -buster to pin to an OS version.
99
// Use -bullseye variants on local arm64/Apple Silicon.
10-
"args": { "VARIANT": "22-bullseye" }
10+
"args": { "VARIANT": "24-bullseye" }
1111
},
1212

1313
// Configure tool-specific properties.

.github/workflows/main.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
lfs: "true"
1414
- uses: actions/setup-node@v6
1515
with:
16-
node-version: "22"
16+
node-version-file: ".nvmrc"
1717
cache: "npm"
1818
- run: npm ci
1919
- run: npm run format:ci
@@ -38,7 +38,7 @@ jobs:
3838
lfs: "true"
3939
- uses: actions/setup-node@v6
4040
with:
41-
node-version: "22"
41+
node-version-file: ".nvmrc"
4242
cache: "npm"
4343
- run: npm ci
4444
- run: npm run build
@@ -116,7 +116,7 @@ jobs:
116116
lfs: "true"
117117
- uses: actions/setup-node@v6
118118
with:
119-
node-version: "22"
119+
node-version-file: ".nvmrc"
120120
cache: "npm"
121121
- run: npm ci
122122

.github/workflows/update-zudoku.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Install Node.js
2727
uses: actions/setup-node@v6
2828
with:
29-
node-version: "22"
29+
node-version-file: ".nvmrc"
3030
registry-url: "https://registry.npmjs.org"
3131
cache: "npm"
3232

0 commit comments

Comments
 (0)