fix: cell.style.fill problems old pr 1573

Author: CTyrannosaurus

lib/doc/cell.js

@@ -349,7 +349,7 @@ class Cell {
     }
 
     if (value.style) {
-      this.style = value.style;
+      this.style = _.cloneDeep(value.style);
     } else {
       this.style = {};
     }
@@ -862,8 +862,7 @@ class FormulaValue {
     if (!this._translatedFormula && this.model.sharedFormula) {
       const {worksheet} = this.cell;
       const master = worksheet.findCell(this.model.sharedFormula);
-      this._translatedFormula =
-        master && slideFormula(master.formula, master.address, this.model.address);
+      this._translatedFormula = master && slideFormula(master.formula, master.address, this.model.address);
     }
     return this._translatedFormula;
   }

lib/utils/under-dash.js

@@ -179,6 +179,34 @@ const _ = {
     }
     return target;
   },
+
+  cloneDeep: function cloneDeep(value, preserveUndefined) {
+    if (preserveUndefined === undefined) {
+      preserveUndefined = true;
+    }
+    let clone;
+    if (value === null) {
+      return null;
+    }
+    if (value instanceof Date) {
+      return value;
+    }
+    if (value instanceof Array) {
+      clone = [];
+    } else if (typeof value === 'object') {
+      clone = {};
+    } else {
+      return value;
+    }
+    _.each(value, (_value, name) => {
+      if (_value !== undefined) {
+        clone[name] = cloneDeep(_value, preserveUndefined);
+      } else if (preserveUndefined) {
+        clone[name] = undefined;
+      }
+    });
+    return clone;
+  },
 };
 
 module.exports = _;

spec/integration/workbook/workbook.spec.js

@@ -639,9 +639,13 @@ describe('Workbook', () => {
               const ws2 = wb2.getWorksheet('duplicateTest');
 
               expect(ws2.getCell('A2').value).to.equal('OneInfo');
-              expect(ws2.getCell('A2').style).to.equal(ws2.getCell('A1').style);
+              expect(ws2.getCell('A2').style).to.deep.equal(
+                ws2.getCell('A1').style
+              );
               expect(ws2.getCell('A3').value).to.equal('OneInfo');
-              expect(ws2.getCell('A3').style).to.equal(ws2.getCell('A1').style);
+              expect(ws2.getCell('A3').style).to.deep.equal(
+                ws2.getCell('A1').style
+              );
               expect(ws2.getCell('A4').value).to.be.null();
             });
         });

spec/unit/utils/under-dash.spec.js

@@ -76,4 +76,51 @@ describe('under-dash', () => {
       }
     });
   });
+
+  describe('cloneDeep', () => {
+    it('should be null', () => {
+      const clone = _.cloneDeep(null);
+
+      expect(clone).to.be.equal(null);
+    });
+    it('should be date', () => {
+      const myDate = new Date(Date.UTC(2017, 11, 15, 17, 0, 0, 0));
+      const cloneDate = _.cloneDeep(myDate);
+
+      expect(cloneDate).to.deep.equal(myDate);
+    });
+    it('should be string', () => {
+      const clone = _.cloneDeep('string');
+
+      expect(clone).to.equal('string');
+    });
+    it('should be array', () => {
+      const origin = [1, 2, [3, undefined, [5]]];
+      const clone = _.cloneDeep(origin);
+
+      expect(clone).to.deep.equal(origin);
+
+      origin.push(6);
+
+      expect(clone).not.to.deep.equal(origin);
+    });
+    it('should be object', () => {
+      const origin = {
+        name: 'test',
+        goods: [1, 2, 3, [4]],
+        theme: {
+          font: 'red',
+          size: 12,
+          border: undefined,
+        },
+      };
+      const clone = _.cloneDeep(origin);
+
+      expect(clone).to.deep.equal(origin);
+
+      origin.theme.size = 13;
+
+      expect(clone).not.to.deep.equal(origin);
+    });
+  });
 });