Skip to content

Commit 0f902b1

Browse files
committed
修复:golangci-lint 报告的代码质量问题
- 修复 errcheck 问题:为 UserSession.UpdateIsActive 和 CleanExpiredSessions 方法添加错误检查 - 修复 staticcheck 问题:为 UpdateUserUploadStats 的空 if 分支添加日志记录 - 添加适当的错误日志记录,不影响主要功能流程
1 parent 7f64df4 commit 0f902b1

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

internal/services/auth.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"encoding/hex"
66
"errors"
77
"fmt"
8+
"log"
89
"regexp"
910
"strings"
1011
"time"
@@ -440,7 +441,10 @@ func (s *AuthService) ValidateToken(tokenString string) (*AuthClaims, error) {
440441

441442
// 检查会话是否过期
442443
if session.ExpiresAt.Before(time.Now()) {
443-
s.daoManager.UserSession.UpdateIsActive(session, false)
444+
if err := s.daoManager.UserSession.UpdateIsActive(session, false); err != nil {
445+
// 记录错误但继续处理
446+
log.Printf("Failed to update session active status: %v", err)
447+
}
444448
return nil, errors.New("会话已过期")
445449
}
446450

@@ -496,7 +500,9 @@ func (s *AuthService) createUserSession(user *models.User, ipAddress, userAgent
496500
// 删除最旧的会话
497501
oldestSession, err := s.daoManager.UserSession.GetOldestSessionByUserID(user.ID)
498502
if err == nil {
499-
s.daoManager.UserSession.UpdateIsActive(oldestSession, false)
503+
if err := s.daoManager.UserSession.UpdateIsActive(oldestSession, false); err != nil {
504+
log.Printf("Failed to update oldest session active status: %v", err)
505+
}
500506
}
501507
}
502508

@@ -563,7 +569,9 @@ func (s *AuthService) generateSessionID() (string, error) {
563569

564570
// cleanExpiredSessions 清理过期会话
565571
func (s *AuthService) cleanExpiredSessions(userID uint) {
566-
s.daoManager.UserSession.CleanExpiredSessions()
572+
if err := s.daoManager.UserSession.CleanExpiredSessions(); err != nil {
573+
log.Printf("Failed to clean expired sessions: %v", err)
574+
}
567575
}
568576

569577
// invalidateOtherSessions 使其他会话失效

internal/services/share.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"crypto/rand"
55
"crypto/sha256"
66
"fmt"
7+
"log"
78
"mime/multipart"
89
"path/filepath"
910
"time"
@@ -104,7 +105,7 @@ func (s *ShareService) ShareTextWithAuth(req ShareTextRequest) (*models.FileCode
104105
if req.UserID != nil {
105106
if err := s.userService.UpdateUserUploadStats(*req.UserID, int64(textSize)); err != nil {
106107
// 记录错误但不影响上传成功
107-
// 可以考虑使用日志记录这个错误
108+
log.Printf("Failed to update user upload stats: %v", err)
108109
}
109110
}
110111

@@ -194,7 +195,7 @@ func (s *ShareService) ShareFileWithAuth(req ShareFileRequest) (*models.FileCode
194195
if req.UserID != nil {
195196
if err := s.userService.UpdateUserUploadStats(*req.UserID, req.File.Size); err != nil {
196197
// 记录错误但不影响上传成功
197-
// 可以考虑使用日志记录这个错误
198+
log.Printf("Failed to update user upload stats: %v", err)
198199
}
199200
}
200201

0 commit comments

Comments
 (0)