optimize code

Author: zzh1991

src/main/java/com/zzhpro/movie/service/MovieService.java

@@ -117,6 +117,8 @@ private void saveDetailToMovie(MovieTypeEnum movieTypeEnum) {
             try {
                 boolean fetchStatus = future.get();
                 log.warn("update summary success: {}", fetchStatus);
+            } catch (InterruptedException e) {
+                Thread.currentThread().interrupt();
             } catch (Exception e) {
                 log.error("get movie summary error", e);
             }

src/main/java/com/zzhpro/movie/service/db/PageDataService.java

@@ -49,10 +49,10 @@ public Page<Film> getFilmBySearchText(String searchText, Pageable pageable) {
         Specification<Film> specification = null;
         if (!specificationList.isEmpty()) {
             specification = Specification.where(specificationList.get(0));
-        }
 
-        for (int i = 1; i < specificationList.size(); i++) {
-            specification = specification.or(specificationList.get(i));
+            for (int i = 1; i < specificationList.size(); i++) {
+                specification = specification.or(specificationList.get(i));
+            }
         }
 
         return filmRepository.findAll(specification, pageable);

src/main/java/com/zzhpro/movie/util/ConstantUtils.java

@@ -6,5 +6,7 @@
  * @since 3/8/20
  */
 public final class ConstantUtils {
+
+    private ConstantUtils() { }
     public static final String SEPARATOR = ",";
 }

src/test/java/com/zzhpro/movie/dao/FilmRepositoryTest.java

@@ -32,22 +32,22 @@ void findFirstByMovieId() {
     @Sql(scripts = { "/test-film-data.sql" })
     void findByMovieIdIsIn() {
         List<Film> filmList = filmRepository.findByMovieIdIsIn(Lists.newArrayList(MOVIE_ID));
-        assertThat(filmList.size()).isEqualTo(1);
+        assertThat(filmList).hasSize(1);
     }
 
     @Transactional
     @Test
     @Sql(scripts = { "/test-film-data.sql" })
     void findAllByOrderByMovieYearDescRatingDesc() {
         List<Film> filmList = filmRepository.findAllByOrderByMovieYearDescRatingDesc();
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 
     @Transactional
     @Test
     @Sql(scripts = { "/test-film-data.sql" })
     void findByMovieTypeEnumOrderByRatingDesc() {
         List<Film> filmList = filmRepository.findByMovieTypeEnumOrderByRatingDesc(MovieTypeEnum.TOP);
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 }

src/test/java/com/zzhpro/movie/mapper/FilmMapperTest.java

@@ -26,7 +26,7 @@ void listAllFilms() {
                 .orderByDesc(Film::getMovieYear)
                 .orderByDesc(Film::getRating)
         );
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 
     @Transactional
@@ -37,6 +37,6 @@ void listFilmsByMovieTypeEnum() {
                 .eq(Film::getMovieTypeEnum, MovieTypeEnum.TOP)
                 .orderByDesc(Film::getRating)
         );
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 }

src/test/java/com/zzhpro/movie/service/MovieServiceTest.java

@@ -47,13 +47,13 @@ void findByMovieId() {
     void getMoviesByMovieTypeEnum() {
         when(dataService.listFilmsByMovieTypeEnum(MovieTypeEnum.TOP)).thenReturn(FILM_LIST);
         List<Film> filmList = movieService.getMoviesByMovieTypeEnum(MovieTypeEnum.TOP);
-        assertThat(filmList.size()).isEqualTo(FILM_LIST.size());
+        assertThat(filmList).hasSameSizeAs(FILM_LIST);
     }
 
     @Test
     void getAllMovies() {
         when(dataService.listAllFilms()).thenReturn(FILM_LIST);
         List<Film> filmList = movieService.getAllMovies();
-        assertThat(filmList.size()).isEqualTo(FILM_LIST.size());
+        assertThat(filmList).hasSameSizeAs(FILM_LIST);
     }
 }

src/test/java/com/zzhpro/movie/service/db/DataServiceTest.java

@@ -33,31 +33,31 @@ void findByMovieId() {
     @Sql(scripts = { "/test-film-data.sql" })
     void findByMovieIds() {
         List<Film> filmList = dataService.findByMovieIds(Lists.newArrayList(MOVIE_ID));
-        assertThat(filmList.size()).isEqualTo(1);
+        assertThat(filmList).hasSize(1);
     }
 
     @Transactional
     @Test
     @Sql(scripts = { "/test-film-data.sql" })
     void findByMovieTypeEnum() {
         List<Film> filmList = dataService.findByMovieTypeEnum(MovieTypeEnum.TOP);
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 
     @Transactional
     @Test
     @Sql(scripts = { "/test-film-data.sql" })
     void listFilmsByMovieTypeEnum() {
         List<Film> filmList = dataService.findByMovieTypeEnum(MovieTypeEnum.TOP);
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 
     @Transactional
     @Test
     @Sql(scripts = { "/test-film-data.sql" })
     void listAllFilms() {
         List<Film> filmList = dataService.listAllFilms();
-        assertThat(filmList.isEmpty()).isFalse();
+        assertThat(filmList).isNotEmpty();
     }
 
     @Transactional