SkipIfGitHubActionsFactAttribute

Author: StefH

test/EntityFramework.DynamicLinq.Tests/EntityFramework.DynamicLinq.Tests.csproj

@@ -29,6 +29,10 @@
         <Compile Include="..\System.Linq.Dynamic.Core.Tests\TestClasses\*.cs" />
     </ItemGroup>
 
+    <ItemGroup>
+      <Compile Remove="..\System.Linq.Dynamic.Core.Tests\TestHelpers\SkipIfGitHubActionsAttribute.cs" />
+    </ItemGroup>
+
     <ItemGroup>
         <ProjectReference Include="..\..\src\System.Linq.Dynamic.Core\System.Linq.Dynamic.Core.csproj" />
         <ProjectReference Include="..\..\src\EntityFramework.DynamicLinq\EntityFramework.DynamicLinq.csproj" />

test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs

@@ -217,7 +217,7 @@ public void DynamicClass_GetRuntimeType()
         typeOf.ToString().Should().Be("System.Linq.Dynamic.Core.DynamicClass");
     }
 
-    [SkipIfGitHubActions]
+    [SkipIfGitHubActionsFact]
     public void DynamicClassArray()
     {
         // Arrange
@@ -249,7 +249,7 @@ public void DynamicClassArray()
         isValid.Should().BeTrue();
     }
 
-    [SkipIfGitHubActions]
+    [SkipIfGitHubActionsFact]
     public void DynamicClassArray_Issue593_Fails()
     {
         // Arrange
@@ -281,7 +281,7 @@ public void DynamicClassArray_Issue593_Fails()
         isValid.Should().BeFalse(); // This should actually be true, but fails. For solution see Issue593_Solution1 and Issue593_Solution2.
     }
 
-    [SkipIfGitHubActions]
+    [SkipIfGitHubActionsFact]
     public void DynamicClassArray_Issue593_Solution1()
     {
         // Arrange
@@ -318,7 +318,7 @@ public void DynamicClassArray_Issue593_Solution1()
         isValid.Should().BeTrue();
     }
 
-    [SkipIfGitHubActions]
+    [SkipIfGitHubActionsFact]
     public void DynamicClassArray_Issue593_Solution2()
     {
         // Arrange

test/System.Linq.Dynamic.Core.Tests/DynamicGetMemberBinderTests.cs

@@ -1,5 +1,5 @@
-#if !NET461
-using System.Data;
+using System.Data;
+using System.Linq.Dynamic.Core.Tests.TestHelpers;
 using FluentAssertions;
 using Xunit;
 
@@ -82,7 +82,7 @@ public void DynamicGetMemberBinder_SelectTypeOnArrayWithComplexObjects()
         ordered.Should().HaveCount(6);
     }
 
-    [Fact]
+    [SkipIfGitHubActionsFact]
     public void DynamicGetMemberBinder_SelectOnDataTable()
     {
         // Arrange
@@ -96,10 +96,7 @@ public void DynamicGetMemberBinder_SelectOnDataTable()
         dataTable.Rows.Add("South", "Apples", 200);
         dataTable.Rows.Add("South", "Oranges", 250);
 
-        var extractedRows =
-            from row in dataTable.AsEnumerable()
-            select row;
-        var rows = extractedRows.AsQueryable();
+        var rows = dataTable.Rows.Cast<DataRow>().AsQueryable();
 
         // Act
         var grouping1 = rows
@@ -117,7 +114,7 @@ from row in dataTable.AsEnumerable()
         ordered.Should().HaveCount(6);
     }
 
-    [Fact]
+    [SkipIfGitHubActionsFact]
     public void DynamicGetMemberBinder_SelectTypeOnDataTable()
     {
         // Arrange
@@ -131,10 +128,7 @@ public void DynamicGetMemberBinder_SelectTypeOnDataTable()
         dataTable.Rows.Add("South", "Apples", 200);
         dataTable.Rows.Add("South", "Oranges", 250);
 
-        var extractedRows =
-            from row in dataTable.AsEnumerable()
-            select row;
-        var rows = extractedRows.AsQueryable();
+        var rows = dataTable.Rows.Cast<DataRow>().AsQueryable();
 
         // Act
         var grouping1 = rows
@@ -175,5 +169,4 @@ public void DynamicGetMemberBinder_SelectOnArrayWithIntegers()
         dynamicResult1.Should().HaveCount(2);
         dynamicResult2.Should().BeEquivalentTo([2, 4]);
     }
-}
-#endif
+}

test/System.Linq.Dynamic.Core.Tests/TestHelpers/SkipIfGitHubActionsAttribute.cs renamed to test/System.Linq.Dynamic.Core.Tests/TestHelpers/SkipIfGitHubActionsFactAttribute.cs

@@ -2,9 +2,9 @@
 
 namespace System.Linq.Dynamic.Core.Tests.TestHelpers;
 
-internal class SkipIfGitHubActionsAttribute : FactAttribute
+internal class SkipIfGitHubActionsFactAttribute : FactAttribute
 {
-    public SkipIfGitHubActionsAttribute()
+    public SkipIfGitHubActionsFactAttribute()
     {
         if (IsRunningOnGitHubActions())
         {