Validation error when including in the -all project

[LukeJordanMaps]

I have been trying to get acs-commons installing as part of the build process. I followed the manual steps here:

https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html

                        <subPackage>
                            <groupId>com.adobe.acs</groupId>
                            <artifactId>acs-aem-commons-all</artifactId>
                            <filter>true</filter>
                            <isAllVersionsFilter>true</isAllVersionsFilter>
                        </subPackage>
                    </subPackages>

and:

        <dependency>
            <groupId>com.adobe.acs</groupId>
            <artifactId>acs-aem-commons-all</artifactId>
            <version>6.17.2</version>
            <type>zip</type>
        </dependency>

Somehow, it's not building and I cannot for the life of me figure out why others haven't faced this same issue. Why is the validator triggering for this and failing the build?

[INFO] End validating sub package.
[INFO] Start validating sub package '/Users/username/dev/code/repo-name/all/target/com.orgname.all-1.0.0-SNAPSHOT.zip/jcr_root/etc/packages/adobe/consulting/acs-aem-commons-all-6.17.2.zip/jcr_root/apps/acs-commons/install/acs-aem-commons-ui.config-6.17.2.zip'...
[INFO] Using 5 validators for package of type CONTAINER: jackrabbit-filter (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator), jackrabbit-properties (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator), jackrabbit-docviewparser (org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator), jackrabbit-oakindex (org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator), jackrabbit-packagetype (org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator)
[ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type 'CONTAINER' is not supposed to contain anything but OSGi bundles/configurations and subpackages!", filePath=jcr_root/apps/acs-commons/config.author/com.adobe.acs.commons.wcm.impl.QrCodeServlet.xml, nodePath=/apps/acs-commons/config.author/com.adobe.acs.commons.wcm.impl.QrCodeServlet
[INFO] End validating sub package.

[ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.2.2:validate-package (default-validate-package) on project com.orgname.all: Found 1 violation(s) (with severity=ERROR). Check above errors for details -> [Help 1]

Any help is much appreciated.

Thanks.

[kwin]

Look at

acs-aem-commons/pom.xml

Line 312 in 3cf8fba

<allowComplexFilterRulesInApplicationPackages>true

and the property allowComplexFilterRulesInApplicationPackages described in http://jackrabbit.apache.org/filevault/validation.html and https://issues.apache.org/jira/browse/JCRVLT-403.

[LukeJordanMaps]

Hi @kwin

Thanks for your prompt response. In all honesty, I'm out of my comfort zone here. I've spent a few days looking into this, trying different things, and that includes "allowComplexFilterRulesInApplicationPackages", but to no avail. It might be that I'm using it incorrectly. Could you advise how to use this correctly for the acs commons package, please?

Here is what I have attempted:

                    <validatorsSettings>
                        <jackrabbit-filter:com.adobe.acs:acs-aem-commons-all>
                            <isDisabled>true</isDisabled>
                            <packageRestriction>
                                <name>com.adobe.acs</name>
                                <group>acs-aem-commons-all</group>
                                <!--subPackageOnly>true</subPackageOnly-->
                            </packageRestriction>
                            <failOnError>false</failOnError>
                        </jackrabbit-filter:com.adobe.acs:acs-aem-commons-all>
                        <jackrabbit-packagetype>
                            <options>
                                <allowComplexFilterRulesInApplicationPackages>true</allowComplexFilterRulesInApplicationPackages>
                                <severityForUncoveredAncestorNodes>warning</severityForUncoveredAncestorNodes>
                            </options>
                        </jackrabbit-packagetype>
                    </validatorsSettings>