Skip to content

Commit 51ed133

Browse files
committed
docs(test): mark ORM plugins tests validated on Aurora (use_pure not needed)
The EC2/Aurora run (2026-06-15) confirmed these salvaged aws#1224 ORM tests pass on mysql-connector's default C extension -- including failover_during_query, iam_plugin, and secrets_manager variants. The README's C-extension is_connected-blocks concern did not bite, so use_pure=True is not required. Replace the now-resolved PENDING VERIFICATION note with the validated result.
1 parent 592a277 commit 51ed133

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

tests/integration/container/sqlalchemy/test_sqlalchemy_plugins.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919
Salvaged from main's PR #1224 and now bound to the wrapper's own dialect via
2020
the ``mysql+aws_wrapper_mysqlconnector://`` URL (see SqlAlchemySupport.md).
2121
22-
PENDING VERIFICATION (do after the EC2/Aurora run confirms the merge is
23-
clean): these tests connect with mysql-connector's default C extension --
24-
they do NOT set ``use_pure=True``. The README recommends ``use_pure=True``
25-
for Aurora MySQL because the C extension's ``is_connected`` can block
26-
indefinitely on network failure, which is exactly what the failover tests
27-
here provoke. If these flake/hang on failover, add ``use_pure=True`` to the
28-
engine URLs. Tracked because the wrapper's MySQL SA dialect is already
29-
verified under ``use_pure=True`` elsewhere (test_sqlalchemy.py), but these
30-
ORM-level failover paths are not yet exercised on real Aurora.
22+
Validated on real Aurora MySQL (EC2 run, 2026-06-15): these pass on
23+
mysql-connector's default C extension -- including the failover variants
24+
(failover_during_query, iam_plugin, secrets_manager) -- so ``use_pure=True``
25+
is NOT required here. The README's concern that the C extension's
26+
``is_connected`` can block on network failure did not bite for these
27+
ORM-level failover paths. (The MySQL SA dialect is separately exercised under
28+
``use_pure=True`` in test_sqlalchemy.py.)
3129
"""
3230

3331
from __future__ import annotations

0 commit comments

Comments
 (0)