refactor: clarify repository selection names

Author: rohans0509

src/codealmanac/services/config/service.py

@@ -64,7 +64,7 @@ def set(self, request: SetConfigValueRequest) -> ConfigSetResult:
 
     def project_config_path(self, request: LoadConfigRequest) -> Path | None:
         try:
-            repository = self.repositories.select_read_repository(
+            repository = self.repositories.select_for_read(
                 request.cwd,
                 request.repository_name,
             )

src/codealmanac/services/diagnostics/wiki.py

@@ -52,7 +52,7 @@ def select_repository(
     repositories: RepositoriesService,
 ) -> Repository | DoctorCheck:
     try:
-        return repositories.select_read_repository(request.cwd, request.repository_name)
+        return repositories.select_for_read(request.cwd, request.repository_name)
     except NoRepositorySelected:
         return DoctorCheck(
             key="wiki.none",

src/codealmanac/services/health/service.py

@@ -57,7 +57,7 @@ def ensure_valid(self, repository: Repository) -> ValidationResult:
         return result
 
     def select_repository(self, cwd: Path, repository_name: str | None) -> Repository:
-        return self.repositories.select_read_repository(cwd, repository_name)
+        return self.repositories.select_for_read(cwd, repository_name)
 
 
 def validation_result(

src/codealmanac/services/index/service.py

@@ -35,7 +35,7 @@ def ensure_fresh(self, repository_id: str) -> IndexRefreshResult:
         )
 
     def reindex(self, request: ReindexRequest) -> IndexRefreshResult:
-        repository = self.repositories.select_read_repository(
+        repository = self.repositories.select_for_read(
             request.cwd,
             request.repository_name,
         )

src/codealmanac/services/pages/service.py

@@ -11,7 +11,7 @@ def __init__(self, repositories: RepositoriesService, index: IndexService):
         self.index = index
 
     def show(self, request: ShowPageRequest) -> PageView:
-        repository = self.repositories.select_read_repository(
+        repository = self.repositories.select_for_read(
             request.cwd,
             request.repository_name,
         )

src/codealmanac/services/repositories/service.py

@@ -82,13 +82,13 @@ def get(self, repository_id: str) -> Repository:
             raise NotFoundError("repository", repository_id)
         return entry.to_repository()
 
-    def find_by_path(self, path: Path) -> Repository | None:
-        entry = self.store.find_by_path(path)
+    def find_by_root_path(self, path: Path) -> Repository | None:
+        entry = self.store.find_by_root_path(path)
         if entry is None:
             return None
         return entry.to_repository()
 
-    def select(self, request: SelectRepositoryRequest) -> Repository:
+    def select_by_name(self, request: SelectRepositoryRequest) -> Repository:
         entries = self.store.list()
         selected = select_repository_record(request, entries)
         if selected is not None:
@@ -102,17 +102,17 @@ def resolve(self, path: Path) -> Repository:
             return exact.to_repository()
         raise NoRepositorySelected()
 
-    def select_operation_repository(
+    def select_for_operation(
         self,
         cwd: Path,
         repository_name: str | None,
     ) -> Repository:
         if repository_name is None:
             return self.resolve(cwd)
-        return self.select(SelectRepositoryRequest(name=repository_name))
+        return self.select_by_name(SelectRepositoryRequest(name=repository_name))
 
-    def resolve_read_repository(self, path: Path) -> Repository:
-        registered = self.find_by_path(path)
+    def repository_for_read_path(self, path: Path) -> Repository:
+        registered = self.find_by_root_path(path)
         if registered is not None:
             return registered
         normalized = normalize_path(path)
@@ -125,14 +125,14 @@ def resolve_read_repository(self, path: Path) -> Repository:
             )
         raise NoRepositorySelected()
 
-    def select_read_repository(
+    def select_for_read(
         self,
         cwd: Path,
         repository_name: str | None,
     ) -> Repository:
         if repository_name is None:
-            return self.resolve_read_repository(cwd)
-        return self.select(SelectRepositoryRequest(name=repository_name))
+            return self.repository_for_read_path(cwd)
+        return self.select_by_name(SelectRepositoryRequest(name=repository_name))
 
     def validate_path(self, repository_id: str, path: Path) -> Path:
         repository = self.get(repository_id)

src/codealmanac/services/repositories/store.py

@@ -56,7 +56,7 @@ def find_by_repository_id(self, repository_id: str) -> RepositoryRecord | None:
             return None
         return repository_record_from_row(row)
 
-    def find_by_path(self, path: Path) -> RepositoryRecord | None:
+    def find_by_root_path(self, path: Path) -> RepositoryRecord | None:
         normalized = normalize_path(path)
         with self.connect() as connection:
             row = connection.execute(

src/codealmanac/services/runs/service.py

@@ -153,7 +153,9 @@ def cancel(self, request: CancelRunRequest) -> RunCancelResult:
     def selected_repository(self, repository_name: str | None) -> Repository | None:
         if repository_name is None:
             return None
-        return self.repositories.select(SelectRepositoryRequest(name=repository_name))
+        return self.repositories.select_by_name(
+            SelectRepositoryRequest(name=repository_name)
+        )
 
     def require_selected_run(
         self,

src/codealmanac/services/search/service.py

@@ -11,7 +11,7 @@ def __init__(self, repositories: RepositoriesService, index: IndexService):
         self.index = index
 
     def search(self, request: SearchPagesRequest) -> tuple[SearchPageResult, ...]:
-        repository = self.repositories.select_read_repository(
+        repository = self.repositories.select_for_read(
             request.cwd,
             request.repository_name,
         )

src/codealmanac/services/topics/repository.py

@@ -9,4 +9,4 @@ def resolve_topic_repository(
     cwd: Path,
     repository_name: str | None,
 ) -> Repository:
-    return repositories.select_read_repository(cwd, repository_name)
+    return repositories.select_for_read(cwd, repository_name)