refactor: align server repository selection names

Author: rohans0509

src/codealmanac/server/api_routes.py

@@ -28,10 +28,10 @@
 class ServerApiContext:
     codealmanac: CodeAlmanac
     cwd: Path
-    scope_wiki: str | None = None
+    scoped_repository_name: str | None = None
 
-    def selected_wiki(self, request_wiki: str | None) -> str | None:
-        return self.scope_wiki or request_wiki
+    def repository_name(self, request_wiki: str | None) -> str | None:
+        return self.scoped_repository_name or request_wiki
 
 
 def register_api_routes(server: FastAPI, context: ServerApiContext) -> None:
@@ -40,8 +40,8 @@ def overview(wiki: str | None = None) -> ViewerOverview:
         return context.codealmanac.viewer.overview(
             ViewerOverviewRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
-                include_repositories=context.scope_wiki is None,
+                repository_name=context.repository_name(wiki),
+                include_repositories=context.scoped_repository_name is None,
             )
         )
 
@@ -50,7 +50,7 @@ def page(slug: str, wiki: str | None = None) -> ViewerPage:
         return context.codealmanac.viewer.page(
             ViewerPageRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 slug=slug,
             )
         )
@@ -64,7 +64,7 @@ def search(
         return context.codealmanac.viewer.search(
             ViewerSearchRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 query=q,
                 limit=limit,
             )
@@ -79,7 +79,7 @@ def file_route(
         return context.codealmanac.viewer.file(
             ViewerFileRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 path=path,
                 limit=limit,
             )
@@ -94,7 +94,7 @@ def topic(
         return context.codealmanac.viewer.topic(
             ViewerTopicRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 slug=slug,
                 include_descendants=descendants,
             )
@@ -105,7 +105,7 @@ def jobs(limit: int | None = None, wiki: str | None = None) -> ViewerJobs:
         return context.codealmanac.viewer.jobs(
             ViewerJobsRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 limit=limit,
             )
         )
@@ -115,7 +115,7 @@ def job(run_id: str, wiki: str | None = None) -> ViewerJob:
         return context.codealmanac.viewer.job(
             ViewerJobRequest(
                 cwd=context.cwd,
-                repository_name=context.selected_wiki(wiki),
+                repository_name=context.repository_name(wiki),
                 run_id=run_id,
             )
         )

src/codealmanac/server/app.py

@@ -17,7 +17,11 @@ def create_server_app(
     register_error_handlers(server)
     register_api_routes(
         server,
-        ServerApiContext(codealmanac=codealmanac, cwd=cwd, scope_wiki=wiki),
+        ServerApiContext(
+            codealmanac=codealmanac,
+            cwd=cwd,
+            scoped_repository_name=wiki,
+        ),
     )
     register_static_routes(server)
 

tests/test_server.py

@@ -5,7 +5,7 @@
 from codealmanac.app import CodeAlmanac
 from codealmanac.server.app import create_server_app
 from codealmanac.services.harnesses.models import HarnessEvent, HarnessEventKind
-from codealmanac.services.repositories.requests import InitializeRepositoryRequest
+from codealmanac.services.repositories.requests import RegisterRepositoryRequest
 from codealmanac.services.runs.models import RunEventKind, RunKind, RunStatus
 from codealmanac.services.runs.requests import (
     FinishRunRequest,
@@ -103,7 +103,8 @@ def test_server_viewer_api_switches_between_registered_wikis(
     repo, app = viewer_repo
     other_repo = tmp_path / "other"
     other_repo.mkdir()
-    other = app.workflows.build.initialize(InitializeRepositoryRequest(path=other_repo))
+    other = app.repositories.register(RegisterRepositoryRequest(root_path=other_repo))
+    app.wiki.initialize(other.repository_id)
     write_server_page(
         other_repo,
         "ops-note.md",
@@ -119,12 +120,12 @@ def test_server_viewer_api_switches_between_registered_wikis(
     client = TestClient(create_server_app(app, repo))
 
     overview = client.get("/api/overview")
-    other_overview = client.get("/api/overview", params={"wiki": other.repository_id})
+    other_overview = client.get("/api/overview", params={"wiki": other.name})
     other_page = client.get(
         "/api/page/ops-note",
-        params={"wiki": other.repository_id},
+        params={"wiki": other.name},
     )
-    locked_client = TestClient(create_server_app(app, repo, other.repository_id))
+    locked_client = TestClient(create_server_app(app, repo, other.name))
     locked_overview = locked_client.get("/api/overview")
     locked_page = locked_client.get("/api/page/ops-note")
 
@@ -221,17 +222,17 @@ def write_server_page(repo: Path, name: str, body: str) -> None:
 
 
 def create_server_run(repo: Path, app: CodeAlmanac):
+    repository = app.repositories.resolve(repo)
     record = app.runs.start(
         StartRunRequest(
-            cwd=repo,
+            repository_id=repository.repository_id,
             kind=RunKind.INGEST,
             title="Digest auth note",
         )
     )
-    app.runs.mark_running(MarkRunRunningRequest(cwd=repo, run_id=record.run_id))
+    app.runs.mark_running(MarkRunRunningRequest(run_id=record.run_id))
     app.runs.record_event(
         RecordRunEventRequest(
-            cwd=repo,
             run_id=record.run_id,
             kind=RunEventKind.OUTPUT,
             message="Created auth-flow.md",
@@ -243,7 +244,6 @@ def create_server_run(repo: Path, app: CodeAlmanac):
     )
     return app.runs.finish(
         FinishRunRequest(
-            cwd=repo,
             run_id=record.run_id,
             status=RunStatus.DONE,
             summary="updated wiki",